Skip to content

Harden golangci-lint install against invalid release downloads #36011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
May 31, 2026
Merged

Harden golangci-lint install against invalid release downloads #36011

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc645b8
Initial plan
Copilot May 30, 2026
56d405b
chore: outline plan for golangci-lint install hardening
Copilot May 30, 2026
8251c22
fix: harden golangci-lint download retries
Copilot May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 34 additions & 9 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,17 +417,42 @@ install-golangci-lint:
fi; \
DOWNLOAD_URL="https://github.com/golangci/golangci-lint/releases/download/$$GOLANGCI_LINT_VERSION/golangci-lint-$${GOLANGCI_LINT_VERSION#v}-$$GOOS-$$GOARCH.tar.gz"; \
TEMP_DIR=$$(mktemp -d); \
ARCHIVE="$$TEMP_DIR/golangci-lint.tar.gz"; \
EXTRACT_DIR="$$TEMP_DIR/extract"; \
MAX_ATTEMPTS=3; \
RETRY_DELAY=2; \
trap "rm -rf $$TEMP_DIR" EXIT; \
echo "Downloading golangci-lint $$GOLANGCI_LINT_VERSION for $$GOOS/$$GOARCH..."; \
if curl -sSL "$$DOWNLOAD_URL" | tar -xz -C "$$TEMP_DIR"; then \
mkdir -p "$$GOPATH/bin"; \
mv "$$TEMP_DIR"/golangci-lint-*/$$BINARY_NAME "$$GOPATH/bin/$$BINARY_NAME"; \
chmod +x "$$GOPATH/bin/$$BINARY_NAME"; \
echo "✓ golangci-lint $$GOLANGCI_LINT_VERSION installed to $$GOPATH/bin/$$BINARY_NAME"; \
else \
echo "Error: Failed to download golangci-lint from $$DOWNLOAD_URL"; \
exit 1; \
fi
for attempt in $$(seq 1 $$MAX_ATTEMPTS); do \
rm -f "$$ARCHIVE"; \
rm -rf "$$EXTRACT_DIR"; \
mkdir -p "$$EXTRACT_DIR"; \
if curl --fail --silent --show-error --location "$$DOWNLOAD_URL" -o "$$ARCHIVE"; then \
MAGIC_BYTES=$$(od -An -tx1 -N2 "$$ARCHIVE" | tr -d '[:space:]'); \
if [ "$$MAGIC_BYTES" != "1f8b" ]; then \
echo "Warning: Downloaded golangci-lint archive is not a gzip stream (attempt $$attempt/$$MAX_ATTEMPTS)"; \
elif ! tar -tzf "$$ARCHIVE" >/dev/null 2>&1; then \
echo "Warning: Downloaded golangci-lint archive failed validation (attempt $$attempt/$$MAX_ATTEMPTS)"; \
elif tar -xzf "$$ARCHIVE" -C "$$EXTRACT_DIR" && \
mkdir -p "$$GOPATH/bin" && \
mv "$$EXTRACT_DIR"/golangci-lint-*/$$BINARY_NAME "$$GOPATH/bin/$$BINARY_NAME" && \
chmod +x "$$GOPATH/bin/$$BINARY_NAME"; then \
echo "✓ golangci-lint $$GOLANGCI_LINT_VERSION installed to $$GOPATH/bin/$$BINARY_NAME"; \
exit 0; \
else \
echo "Warning: Failed to extract or install golangci-lint archive (attempt $$attempt/$$MAX_ATTEMPTS)"; \
fi; \
else \
echo "Warning: Failed to download golangci-lint archive (attempt $$attempt/$$MAX_ATTEMPTS)"; \
fi; \
if [ "$$attempt" -lt "$$MAX_ATTEMPTS" ]; then \
echo "Retrying golangci-lint download in $$RETRY_DELAY seconds..."; \
sleep $$RETRY_DELAY; \
RETRY_DELAY=$$((RETRY_DELAY * 2)); \
fi; \
done; \
echo "Error: Failed to download a valid golangci-lint archive from $$DOWNLOAD_URL after $$MAX_ATTEMPTS attempts"; \
exit 1

# License compliance checking
.PHONY: license-check
Expand Down