enforce: add contextcancelnotdeferred and wgdonenotdeferred to CI linter gates - #49755
Merged
pelikhan merged 2 commits intoAug 2, 2026
Merged
Conversation
4 tasks
…ter flags Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enforce readiness for contextcancelnotdeferred and wgdonenotdeferred analyzers
enforce: add contextcancelnotdeferred and wgdonenotdeferred to CI linter gates
Aug 2, 2026
pelikhan
marked this pull request as ready for review
August 2, 2026 10:50
Contributor
There was a problem hiding this comment.
Pull request overview
Enforces two existing custom analyzers in CI.
Changes:
- Enables both analyzers for production linting.
- Enables
wgdonenotdeferredfor wasm linting.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Extends custom-linter CI flags. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
|
|
||
| - name: Run custom linters (wasm) | ||
| run: GOOS=js GOARCH=wasm make golint-custom LINTER_FLAGS="-errstringmatch -panicinlibrarycode -manualmutexunlock -osexitinlibrary -rawloginlib -logfatallibrary -regexpcompileinfunction -fprintlnsprintf -strconvparseignorederror -jsonmarshalignoredeerror -uncheckedtypeassertion -fmterrorfnoverbs -tolowerequalfold -httpnoctx -timeafterleak -errortypeassertion -execcommandwithoutcontext -sprintfint -stringsindexcontains -stringscountcontains -bytesbufferstring -ioutildeprecated -mapclearloop -mapdeletecheck -sprintfbool -appendoneelement -timenowsub -stringsjoinone -writebytestring -lenstringsplit -stringreplaceminusone -osgetenvlibrary -ossetenvlibrary -stringsindexhasprefix -test=false" LINTER_PACKAGES="./pkg/console ./pkg/parser ./pkg/styles ./pkg/tty ./pkg/workflow" | ||
| run: GOOS=js GOARCH=wasm make golint-custom LINTER_FLAGS="-errstringmatch -panicinlibrarycode -manualmutexunlock -osexitinlibrary -rawloginlib -logfatallibrary -regexpcompileinfunction -fprintlnsprintf -strconvparseignorederror -jsonmarshalignoredeerror -uncheckedtypeassertion -fmterrorfnoverbs -tolowerequalfold -httpnoctx -timeafterleak -errortypeassertion -execcommandwithoutcontext -sprintfint -stringsindexcontains -stringscountcontains -bytesbufferstring -ioutildeprecated -mapclearloop -mapdeletecheck -sprintfbool -appendoneelement -timenowsub -stringsjoinone -writebytestring -lenstringsplit -stringreplaceminusone -osgetenvlibrary -ossetenvlibrary -stringsindexhasprefix -wgdonenotdeferred -test=false" LINTER_PACKAGES="./pkg/console ./pkg/parser ./pkg/styles ./pkg/tty ./pkg/workflow" |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two audited custom analyzers were registered in
pkg/lintersbut excluded from CI enforcement. Both have zero production violations under the current tree and are safe to gate on.Changes
cgo.ymlline 1362): add-contextcancelnotdeferred -wgdonenotdeferredtoLINTER_FLAGScgo.ymlline 1365): add-wgdonenotdeferredtoLINTER_FLAGS—pkg/console(in scope for this gate) contains async.WaitGroup.Done()site;-contextcancelnotdeferredomitted since its relevant packages (pkg/cli,pkg/workflow,pkg/modelsdev) are outside the wasm gate'sLINTER_PACKAGESBrings enforced analyzer count from 33 → 35.