Closed
fix(spdd): close T-DR test gaps, fix compliance README, promote guard-policies to Implemented#49812
Conversation
10 tasks
- Fix compliance README: reference correct test file (awf_config_drift_formal_test.go) and add T-DR-001..010 to TestFormal_ mapping table - Add missing T-DR-003 (ISO 8601 format), T-DR-005 (no additional properties), and T-DR-008 (PR embeds JSON) tests to formal test file - Add T-DR annotations to all existing formal drift tests - Add json tags to FormalDriftRecord for spec-conformant snake_case field names - Promote guard-policies-specification.md from Draft v0.1.0 to Implemented v0.2.0 - Add Structure section to guard-policies-specification.md with file/module layout - Strengthen safe-outputs-specification.md deletion tracking with grep command and reference to tracking issue #49811 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review daily SPDD rotation for specification files
fix(spdd): close T-DR test gaps, fix compliance README, promote guard-policies to Implemented
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPDD 2026-08-02 rotation identified stale/incorrect references in the DriftRecord conformance suite and two spec files stuck in limbo. Three T-DR test IDs had no implementation, the compliance README pointed to a file that doesn't exist, and
guard-policies-specification.mdremained Draft despite the implementation being complete.P0 — DriftRecord conformance gaps
specs/awf-config-sources-compliance/README.mdawf_config_drift_test.go→awf_config_drift_formal_test.go(the non-formalfile never existed)TestDriftRecord→TestFormal_TestFormal_*mapping table so every conformance ID is traceablepkg/workflow/awf_config_drift_formal_test.go— three uncovered IDs closed:TestFormal_TDR003_DetectedAtISO8601Formattime.Parse(time.RFC3339, ...)rejects non-conforming valuesTestFormal_TDR005_NoAdditionalPropertiesjson.NewDecoder+DisallowUnknownFields()TestFormal_TDR008_CorrectionPREmbedsDriftRecordsAlso added
json:"property_path"etc. snake_case tags toFormalDriftRecordto match the normative spec field names, and// covers T-DR-xxxannotations to all existing tests.scratchpad/safe-outputs-specification.md— archival notice strengthened with agrepone-liner to surface stale references before the 2026-09-21 deletion date, and a cross-reference to tracking issue #49811.P1 — Guard policies Draft resolution
scratchpad/guard-policies-specification.mdpromoted Draft v0.1.0 → Implemented v0.2.0 with a dated decision record. Added a Structure section mapping the fullGuardPoliciestype hierarchy topkg/workflow/files (types, validation, parsing, compilation, safe-outputs derivation, tests).P2 — aw-harness.md safeguards
Already present at §11.2 and §11.4 — no changes needed.