Skip to content

Remove vulnerable embedded cli-proxy:0.27.43 digest pin - #49817

Closed
pelikhan with Copilot wants to merge 2 commits into
mainfrom
copilot/container-image-scan-remediation
Closed

Remove vulnerable embedded cli-proxy:0.27.43 digest pin#49817
pelikhan with Copilot wants to merge 2 commits into
mainfrom
copilot/container-image-scan-remediation

Conversation

Copilot AI commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

The shared action pin metadata still embedded a digest for ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.43, which kept a known-vulnerable image resolvable even though the runtime should be able to fall back to the tag. This change removes that embedded digest pin and aligns workflow pinning expectations with the new fallback behavior.

  • Pin data

    • Remove the cli-proxy:0.27.43 entry from the shared container pin tables:
      • .github/aw/actions-lock.json
      • pkg/actionpins/data/action_pins.json
      • pkg/workflow/data/action_pins.json
    • Preserve the existing embedded pins for the other AWF sidecars (agent, api-proxy, squid).
  • Compiler behavior contract

    • Keep cli-proxy usable via its tagged image reference when no embedded digest pin exists.
    • Continue emitting digest metadata only for sidecars that still have trusted embedded pins.
  • Regression coverage

    • Update focused workflow pinning tests to assert:
      • agent, api-proxy, and squid remain digest-pinned by default
      • cli-proxy falls back to ghcr.io/github/gh-aw-firewall/cli-proxy:<tag>
      • AWF image-tag digest metadata no longer includes cli-proxy=sha256:...
imageTag := strings.TrimPrefix(string(constants.DefaultFirewallVersion), "v")
image := constants.DefaultFirewallRegistry + "/cli-proxy:" + imageTag

refs, pinEntries := applyContainerPins([]string{image}, nil)

// No embedded digest pin: keep the tag reference.
assert.Equal(t, image, refs[0])
assert.Empty(t, pinEntries[0].Digest)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update container image to resolve vulnerabilities Remove vulnerable embedded cli-proxy:0.27.43 digest pin Aug 2, 2026
Copilot AI requested a review from pelikhan August 2, 2026 16:48
@pelikhan pelikhan closed this Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[container-image-scan] Container findings for ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.43

2 participants