refactor: retire fetch type notification setting#3070
Merged
Conversation
TanStack Query owns notification fetching with standard interval polling, so the Interval vs Inactivity choice no longer earns its settings surface. Notifications now always poll on the configured fetch interval; the inactivity timer hook and the settings radio group are removed. A stale fetchType key in previously persisted settings is ignored harmlessly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Interval vs Inactivity fetch type choice now that TanStack Query manages notification fetching in the standard way. Notifications always poll on the configured fetch interval; the interval duration setting stays. The now-unused
useInactivityTimerhook, theFetchTypeenum, and the settings radio group are gone (net -225 lines).Users who had Inactivity selected silently move to interval polling. The stale
fetchTypekey in previously persisted settings is simply ignored by the store's typed accessors, so no storage migration is needed.Closes #3068