fix: rollback failed notification interaction with visual warning - #3145
Open
setchy wants to merge 1 commit into
Open
fix: rollback failed notification interaction with visual warning#3145setchy wants to merge 1 commit into
setchy wants to merge 1 commit into
Conversation
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fix a bug whereby a notification interaction can fail [rate limit, forbidden] leaving gitify in a broken state. manual or timer notification refreshes would not recover state, only a force reload of the app.
Example
Using a GitHub Enterprise Managed User (EMU) account, that has subscribed to a GitHub Cloud (OSS) issue or pull request.
The GitHub EMU security policies prevent API interactions via PAT with GitHub Cloud content.
This throws a
HTTP 403 Forbiddenwhen performingmark as read,mark as doneorunsubscribeinteractions.Before
before.mov
After
Notification state restored on failure [tanstack query]
Visual indicator on notification interaction buttons about reason for failure
Screen.Recording.2026-08-04.at.8.08.04.AM.mov