feat: Add api-model to remove Scorpio’s dependency on Ceres

[benjamin-747]

No description provided.

[github-actions]

Claude finished @benjamin-747's task in 1m 40s —— View job

---

Code Review Complete ✅

I've completed a comprehensive code review of this PR that adds the api-model crate to remove Scorpio's dependency on Ceres.

Todo List

• Read repository guidelines (CLAUDE.md)
• Review new api-model crate structure
• Review changes to ceres package
• Review changes to scorpio package
• Review changes to other affected packages
• Check Cargo.toml dependency changes
• Assess code quality and architecture
• Check for security issues
• Evaluate performance implications
• Verify test coverage
• Check documentation
• Provide comprehensive feedback

---

Review Summary

This PR successfully extracts a shared LatestCommitInfo model into a new api-model crate, removing Scorpio's previous dependency on Ceres. The refactoring is clean and follows good architectural principles by creating a lightweight shared dependency.

Architecture & Design ✅

Strengths:

• Clean separation of concerns: The new api-model crate properly isolates API models from business logic
• Reduced coupling: Scorpio no longer depends on the heavyweight Ceres crate, improving modularity
• Consistent structure: Follows established Rust workspace patterns with proper module organization

Observations:

• The api-model crate is minimal (only LatestCommitInfo currently), which is good for maintainability
• Using workspace dependencies (serde, utoipa) ensures version consistency across the monorepo

Code Quality ✅

api-model/src/git/commit.rs (lines 1-12):

• Clean, well-structured model with appropriate derives
• All fields are properly typed (String types used throughout)
• ToSchema derive for OpenAPI documentation is excellent

ceres/src/model/git.rs (lines 1-80):

• Good refactoring: LatestCommitInfoWrapper properly wraps the imported model
• The From<Commit> implementation is clean and handles the conversion well
• Comment on line 82 documents removed code: // UserInfo removed: author/committer are now plain strings

ceres/src/api_service/commit_ops.rs:

• Properly imports and uses api_model::git::commit::LatestCommitInfo
• All usages correctly updated to use the external type

Potential Issues & Recommendations

1. Missing PR Description ⚠️

The PR has no description explaining:

• Why this refactoring was needed
• What problem it solves
• How it affects the codebase
• Any migration notes for other developers

Recommendation: Add a description explaining the architectural improvement and dependency reduction benefits.

2. Edition Mismatch 🔴

api-model/Cargo.toml (line 4):

edition = "2024"

Issue: Rust edition "2024" doesn't exist yet. Valid editions are: 2015, 2018, 2021.

Recommendation: Change to edition = "2021" to match other crates in the workspace.

Fix this →

3. Missing status Field Semantic Meaning ⚠️

api-model/src/git/commit.rs (line 11):

pub status: String,

Observations:

• The status field is always set to "success" in the wrapper (ceres/src/model/git.rs:77)
• No other values are used throughout the codebase
• The field's purpose and possible values are undocumented

Recommendations:

1. Add documentation explaining what status represents
2. Consider using an enum instead of String:

   #[derive(Serialize, Deserialize, Debug, Clone, ToSchema)]
   pub enum CommitStatus {
       Success,
       // other variants if needed
   }

3. If the field is unused/always constant, consider removing it

4. Scorpio Dependency Format Inconsistency 📝

scorpio/Cargo.toml (line 7):

api-model ={ path = "../api-model"}

Issue: Missing space after = sign, inconsistent with other dependencies in the file.

Recommendation: Change to api-model = { path = "../api-model" } for consistency.

Fix this →

Security ✅

No security vulnerabilities identified:

• No user input handling in the new crate
• No authentication/authorization logic
• Simple data model with serialization only
• All dependencies are workspace-managed and trusted

Performance ✅

Positive Impact:

• Reduced compilation time: Scorpio no longer needs to compile Ceres and its dependencies
• Smaller binary size: Removing unused Ceres code from Scorpio's dependency tree
• Faster development cycles: Changes to Ceres won't trigger Scorpio recompilation

Runtime: No performance impact - same data structures, just relocated.

Testing ⚠️

Missing:

• No tests for the new api-model crate
• No tests verifying the refactoring didn't break existing functionality

Recommendations:

1. Add basic serialization/deserialization tests for LatestCommitInfo:

   #[cfg(test)]
   mod tests {
       use super::*;
       
       #[test]
       fn test_latest_commit_info_serialization() {
           let info = LatestCommitInfo { /* ... */ };
           let json = serde_json::to_string(&info).unwrap();
           let deserialized: LatestCommitInfo = serde_json::from_str(&json).unwrap();
           assert_eq!(info.oid, deserialized.oid);
       }
   }

2. Run existing integration tests to ensure backward compatibility

Documentation 📝

Missing:

• No module-level documentation in api-model/src/lib.rs
• No README or package description in api-model/Cargo.toml
• No inline documentation for the LatestCommitInfo struct fields

Recommendations:

1. Add package description in Cargo.toml:

   description = "Shared API models for Mega Git services"

2. Add documentation to the struct:

   /// Information about the latest commit for a file or directory.
   /// Used across multiple services (Ceres, Scorpio, Mono) for API responses.
   #[derive(Serialize, Deserialize, Debug, Clone, ToSchema)]
   pub struct LatestCommitInfo {
       /// Git commit object ID (SHA-1 hash)
       pub oid: String,
       /// Commit timestamp
       pub date: String,
       // ... etc
   }

Dependency Changes Review ✅

Cargo.toml (root workspace):

• ✅ Correctly adds api-model to workspace members (line 16)
• ✅ Properly defines workspace dependency (line 23)

ceres/Cargo.toml:

• ✅ Adds api-model as dependency (line 13)
• ✅ Maintains all other dependencies

scorpio/Cargo.toml:

• ✅ Adds api-model as path dependency (line 7)
• ✅ Successfully removes implicit Ceres dependency

Other packages (mono, orion, orion-server, jupiter, common):

• ✅ Dependency updates appear correct and necessary for the refactoring

Overall Assessment

Grade: B+ (Good with minor issues)

This is a solid architectural improvement that successfully reduces coupling between Scorpio and Ceres. The refactoring is clean, focused, and follows Rust best practices. The main issues are:

1. 🔴 Critical: Edition "2024" doesn't exist - must fix
2. ⚠️ Important: Missing tests for the new crate
3. ⚠️ Important: Missing documentation and PR description
4. 📝 Minor: Formatting inconsistency in Cargo.toml

Recommendation: Fix the edition issue before merging. Consider adding documentation and tests in a follow-up PR if time is constrained.

---

[genedna]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

This PR introduces a new api-model crate to break the circular dependency between scorpio and ceres by extracting the shared LatestCommitInfo model into a standalone package. This architectural improvement allows scorpio to use Git commit information structures without depending on the larger ceres crate.

Changes:

• Created new api-model crate with LatestCommitInfo struct extracted from ceres
• Updated scorpio to depend on api-model instead of ceres
• Refactored ceres to use LatestCommitInfo from api-model via a wrapper pattern
• Migrated several dependencies in orion and orion-server to use workspace versions for consistency
• Removed unused dependencies (ring, hex, callisto, http-body-util) from various crates

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
api-model/Cargo.toml	New crate configuration with serde and utoipa dependencies
api-model/src/lib.rs	Module declaration for git submodule
api-model/src/git/mod.rs	Module declaration for commit submodule
api-model/src/git/commit.rs	Extracted LatestCommitInfo struct from ceres
Cargo.toml	Added api-model to workspace members and dependencies, updated axum-extra version
scorpio/Cargo.toml	Replaced ceres dependency with api-model
scorpio/src/manager/fetch.rs	Updated import to use api-model
ceres/Cargo.toml	Added api-model dependency, removed unused ring and hex
ceres/src/model/git.rs	Removed LatestCommitInfo definition, added LatestCommitInfoWrapper for internal use
ceres/src/api_service/mod.rs	Updated import to use api-model
ceres/src/api_service/commit_ops.rs	Refactored to use wrapper pattern for username binding mutations
mono/Cargo.toml	Added api-model dependency, removed unused http-body-util, improved reqwest formatting
mono/src/api/router/preview_router.rs	Updated import to use api-model
jupiter/Cargo.toml	Removed unused hex and ring dependencies
common/Cargo.toml	Removed unused callisto dependency
orion/Cargo.toml	Migrated dependencies to workspace versions (anyhow, itertools, thiserror, serial_test), fixed formatting
orion-server/Cargo.toml	Migrated tokio-stream and chrono to workspace versions

[github-actions]

Claude finished @benjamin-747's task in 2m 9s —— View job

---

Code Review Complete ✅

I've completed a comprehensive code review of this PR that adds the api-model crate to remove Scorpio's dependency on Ceres.

Todo List

• Read repository guidelines (CLAUDE.md)
• Review new api-model crate structure
• Review changes to ceres package
• Review changes to scorpio package
• Review Cargo.toml dependency changes
• Verify issues from previous reviews
• Check for additional code quality concerns
• Assess security implications
• Evaluate performance impact
• Review test coverage
• Check documentation
• Provide comprehensive feedback

---

Review Summary

This PR successfully extracts a shared LatestCommitInfo model into a new api-model crate, removing Scorpio's previous dependency on Ceres. The refactoring is clean and follows good architectural principles by creating a lightweight shared dependency.

Architecture & Design ✅

Strengths:

• Clean separation of concerns: The new api-model crate properly isolates API models from business logic
• Reduced coupling: Scorpio no longer depends on the heavyweight Ceres crate, improving modularity
• Consistent structure: Follows established Rust workspace patterns with proper module organization

Observations:

• The api-model crate is minimal (only LatestCommitInfo currently), which is good for maintainability
• Using workspace dependencies (serde, utoipa) ensures version consistency across the monorepo

Code Quality ✅

api-model/src/git/commit.rs (lines 1-12):

• Clean, well-structured model with appropriate derives
• All fields are properly typed (String types used throughout)
• ToSchema derive for OpenAPI documentation is excellent

ceres/src/model/git.rs (lines 1-80):

• Good refactoring: LatestCommitInfoWrapper properly wraps the imported model
• The From<Commit> implementation is clean and handles the conversion well
• Comment on line 82 documents removed code: // UserInfo removed: author/committer are now plain strings

ceres/src/api_service/commit_ops.rs:

• Properly imports and uses api_model::git::commit::LatestCommitInfo
• All usages correctly updated to use the external type
• Username binding logic (lines 191-208) properly mutates the wrapper to apply bound usernames

Issues Found

1. Missing PR Description ⚠️

The PR has no description explaining:

• Why this refactoring was needed
• What problem it solves
• How it affects the codebase
• Any migration notes for other developers

Recommendation: Add a description explaining the architectural improvement and dependency reduction benefits.

2. Edition Mismatch 🔴

api-model/Cargo.toml (line 4):

edition = "2024"

Issue: Rust edition "2024" doesn't exist yet. Valid editions are: 2015, 2018, 2021.

Recommendation: Change to edition = "2021" to match other crates in the workspace.

Fix this →

Note: I also noticed that mono/Cargo.toml (line 4) and ceres/Cargo.toml (line 4) have the same issue with edition = "2024". These should all be changed to edition = "2021".

3. Missing status Field Semantic Meaning ⚠️

api-model/src/git/commit.rs (line 11):

pub status: String,

Observations:

• The status field is always set to "success" in the wrapper (ceres/src/model/git.rs:77)
• No other values are used throughout the codebase
• The field's purpose and possible values are undocumented

Recommendations:

1. Add documentation explaining what status represents
2. Consider using an enum instead of String:

   #[derive(Serialize, Deserialize, Debug, Clone, ToSchema)]
   pub enum CommitStatus {
       Success,
       // other variants if needed
   }

3. If the field is unused/always constant, consider removing it

4. Scorpio Dependency Format Inconsistency 📝

scorpio/Cargo.toml (line 7):

api-model ={ path = "../api-model"}

Issue: Missing space after = sign, inconsistent with other dependencies in the file.

Recommendation: Change to api-model = { path = "../api-model" } for consistency.

Fix this →

Security ✅

No security vulnerabilities identified:

• No user input handling in the new crate
• No authentication/authorization logic
• Simple data model with serialization only
• All dependencies are workspace-managed and trusted

Performance ✅

Positive Impact:

• Reduced compilation time: Scorpio no longer needs to compile Ceres and its dependencies
• Smaller binary size: Removing unused Ceres code from Scorpio's dependency tree
• Faster development cycles: Changes to Ceres won't trigger Scorpio recompilation

Runtime: No performance impact - same data structures, just relocated.

Testing ⚠️

Missing:

• No tests for the new api-model crate
• No tests verifying the refactoring didn't break existing functionality

Recommendations:

1. Add basic serialization/deserialization tests for LatestCommitInfo:

   #[cfg(test)]
   mod tests {
       use super::*;
       
       #[test]
       fn test_latest_commit_info_serialization() {
           let info = LatestCommitInfo {
               oid: "abc123".to_string(),
               date: "2026-01-14".to_string(),
               short_message: "Test commit".to_string(),
               author: "Author Name".to_string(),
               committer: "Committer Name".to_string(),
               status: "success".to_string(),
           };
           let json = serde_json::to_string(&info).unwrap();
           let deserialized: LatestCommitInfo = serde_json::from_str(&json).unwrap();
           assert_eq!(info.oid, deserialized.oid);
       }
   }

2. Run existing integration tests to ensure backward compatibility

Documentation 📝

Missing:

• No module-level documentation in api-model/src/lib.rs
• No README or package description in api-model/Cargo.toml
• No inline documentation for the LatestCommitInfo struct fields

Recommendations:

1. Add package description in Cargo.toml:

   description = "Shared API models for Mega Git services"

2. Add documentation to the struct:

   /// Information about the latest commit for a file or directory.
   /// Used across multiple services (Ceres, Scorpio, Mono) for API responses.
   #[derive(Serialize, Deserialize, Debug, Clone, ToSchema)]
   pub struct LatestCommitInfo {
       /// Git commit object ID (SHA-1 hash)
       pub oid: String,
       /// Commit timestamp
       pub date: String,
       /// Short commit message (first line)
       pub short_message: String,
       /// Commit author name
       pub author: String,
       /// Committer name
       pub committer: String,
       /// Commit status (typically "success")
       pub status: String,
   }

Dependency Changes Review ✅

Cargo.toml (root workspace):

• ✅ Correctly adds api-model to workspace members (line 16)
• ✅ Properly defines workspace dependency (line 23)

ceres/Cargo.toml:

• ✅ Adds api-model as dependency (line 13)
• ✅ Maintains all other dependencies
• ✅ Removed unused ring and hex dependencies (good cleanup!)

scorpio/Cargo.toml:

• ✅ Adds api-model as path dependency (line 7)
• ✅ Successfully removes implicit Ceres dependency

mono/Cargo.toml:

• ✅ Adds api-model dependency (line 19)
• ✅ Removed unused http-body-util dependency

Other packages (common, jupiter, orion, orion-server):

• ✅ Dependency updates appear correct and necessary for the refactoring
• ✅ Good cleanup: removed unused dependencies (callisto from common, hex and ring from jupiter)

Overall Assessment

Grade: B+ (Good with minor issues)

This is a solid architectural improvement that successfully reduces coupling between Scorpio and Ceres. The refactoring is clean, focused, and follows Rust best practices. The main issues are:

1. 🔴 Critical: Edition "2024" doesn't exist - must fix in api-model, mono, and ceres Cargo.toml files
2. ⚠️ Important: Missing tests for the new crate
3. ⚠️ Important: Missing documentation and PR description
4. 📝 Minor: Formatting inconsistency in scorpio/Cargo.toml

Recommendation: Fix the edition issue before merging. Consider adding documentation and tests in a follow-up PR if time is constrained.

---

[github-actions]

Claude finished @benjamin-747's task in 1m 56s —— View job

---

Code Review Complete ✅

I've completed a thorough code review of this PR that adds the api-model crate to remove Scorpio's dependency on Ceres.

Todo List

• Read repository guidelines (CLAUDE.md)
• Review the architectural change
• Examine new api-model crate files
• Review changes to ceres package
• Review changes to scorpio package
• Verify edition "2024" issue
• Check for security concerns
• Evaluate performance implications
• Assess test coverage
• Review documentation
• Provide comprehensive feedback

---

Review Summary

This PR successfully extracts the shared LatestCommitInfo model into a new api-model crate, removing Scorpio's dependency on Ceres. The architectural improvement is sound and follows good design principles by creating a lightweight shared dependency that reduces coupling.

Architecture & Design ✅

Strengths:

• Clean separation of concerns: The new api-model crate properly isolates shared API models from business logic
• Reduced coupling: Scorpio no longer depends on the heavyweight Ceres crate, improving modularity and reducing compilation overhead
• Proper workspace structure: Follows established Rust workspace patterns with consistent module organization
• Wrapper pattern in Ceres: The LatestCommitInfoWrapper approach (ceres/src/model/git.rs:66-80) allows Ceres to extend the model while preserving the clean shared type

Observations:

• The api-model crate is minimal (only LatestCommitInfo currently), which is excellent for maintainability
• Using workspace dependencies ensures version consistency across the monorepo
• The refactoring properly updates all consumers (Scorpio, Mono, Ceres) to use the new shared type

Code Quality ✅

api-model/src/git/commit.rs:

• Clean, well-structured model with appropriate derives (Serialize, Deserialize, Debug, Clone, ToSchema)
• All fields are properly typed as String
• OpenAPI documentation support via ToSchema is excellent

ceres/src/model/git.rs:

• Good refactoring: LatestCommitInfoWrapper properly wraps the imported model
• The From<Commit> implementation (lines 68-80) is clean and handles the conversion correctly
• Username binding logic in commit_ops.rs (lines 191-208) properly mutates the wrapper

scorpio/src/manager/fetch.rs:

• Correctly imports and uses api_model::git::commit::LatestCommitInfo
• All usages properly updated

Critical Issues Found

1. 🔴 Invalid Rust Edition "2024"

api-model/Cargo.toml (line 4):

edition = "2024"

Issue: Rust edition "2024" doesn't exist. Valid editions are: 2015, 2018, 2021.

Impact: This will cause compilation errors when the edition is actually validated.

Recommendation: Change to edition = "2021" to match other crates in the workspace.

Fix this →

Note: I also noticed that mono/Cargo.toml (line 4) and ceres/Cargo.toml (line 4) have the same issue. These should all be fixed to edition = "2021".

2. 📝 Formatting Inconsistency in scorpio/Cargo.toml

scorpio/Cargo.toml (line 7):

api-model = { path = "../api-model" }

Issue: Missing space after = sign (currently: api-model ={ path). This is inconsistent with line 8: git-internal = { workspace = true }.

Recommendation: Add space for consistency: api-model = { path = "../api-model" }.

Fix this →

Important Improvements Needed

3. ⚠️ Missing Documentation

api-model crate lacks documentation:

• No package description in Cargo.toml
• No module-level docs in lib.rs
• No documentation on the LatestCommitInfo struct fields

Recommendations:

1. Add package description in api-model/Cargo.toml:

description = "Shared API models for Mega Git services"

2. Add struct documentation in api-model/src/git/commit.rs:

/// Information about the latest commit for a file or directory.
/// Used across multiple Mega services (Ceres, Scorpio, Mono) for API responses.
#[derive(Serialize, Deserialize, Debug, Clone, ToSchema)]
pub struct LatestCommitInfo {
    /// Git commit object ID (SHA-1 hash)
    pub oid: String,
    /// Commit timestamp
    pub date: String,
    /// First line of the commit message
    pub short_message: String,
    /// Commit author name
    pub author: String,
    /// Committer name
    pub committer: String,
    /// Commit status (typically "success")
    pub status: String,
}

4. ⚠️ Missing Tests

No tests exist for the new crate.

Recommendation: Add basic serialization/deserialization tests to ensure the model works correctly:

#[cfg(test)]
mod tests {
    use super::*;
    
    #[test]
    fn test_latest_commit_info_serialization() {
        let info = LatestCommitInfo {
            oid: "abc123def456".to_string(),
            date: "2026-01-14T09:00:00Z".to_string(),
            short_message: "Add api-model crate".to_string(),
            author: "Author Name".to_string(),
            committer: "Committer Name".to_string(),
            status: "success".to_string(),
        };
        
        let json = serde_json::to_string(&info).unwrap();
        let deserialized: LatestCommitInfo = serde_json::from_str(&json).unwrap();
        
        assert_eq!(info.oid, deserialized.oid);
        assert_eq!(info.author, deserialized.author);
    }
}

5. ⚠️ Unclear Semantics of status Field

api-model/src/git/commit.rs (line 11):

pub status: String,

Observations:

• Always set to "success" in ceres/src/model/git.rs:77
• No other values are used throughout the codebase
• Field purpose and possible values are undocumented

Recommendations:

1. Add documentation explaining what status represents and what values are possible
2. Consider using an enum instead of String for type safety:

   #[derive(Serialize, Deserialize, Debug, Clone, ToSchema)]
   pub enum CommitStatus {
       Success,
       // Add other variants if needed in the future
   }

3. If the field is always constant and unused, consider removing it in a future refactoring

6. ⚠️ Missing PR Description

The PR has no description explaining:

• Why this refactoring was needed
• What problem it solves (reducing circular dependencies)
• How it affects the codebase
• Migration notes for other developers

Recommendation: Add a description explaining the architectural improvement and dependency reduction benefits.

Security ✅

No security vulnerabilities identified:

• No user input handling in the new crate
• No authentication/authorization logic
• Simple data model with serialization only
• All dependencies are workspace-managed and trusted

Performance ✅

Positive Impact:

• ✅ Reduced compilation time: Scorpio no longer needs to compile Ceres and its many dependencies
• ✅ Smaller binary size: Removing unused Ceres code from Scorpio's dependency tree
• ✅ Faster development cycles: Changes to Ceres won't trigger Scorpio recompilation
• ✅ No runtime overhead: Same data structures, just relocated

Dependency Changes Review ✅

Root Cargo.toml:

• ✅ Correctly adds api-model to workspace members (line 16)
• ✅ Properly defines workspace dependency (line 23)

ceres/Cargo.toml:

• ✅ Adds api-model as dependency (line 13)
• ✅ Good cleanup: removed unused ring and hex dependencies

scorpio/Cargo.toml:

• ✅ Adds api-model as path dependency (line 7)
• ✅ Successfully removes implicit Ceres dependency
• ⚠️ Minor formatting issue (see issue Fix the empty value in the dependabot.yml #2 above)

mono/Cargo.toml:

• ✅ Adds api-model dependency (line 19)
• ✅ Removed unused http-body-util dependency
• ✅ Improved reqwest formatting

Other packages (common, jupiter, orion, orion-server):

• ✅ Dependency updates are correct
• ✅ Good cleanup: removed unused dependencies (callisto from common, hex and ring from jupiter)

Overall Assessment

Grade: B+ (Good with critical issue)

This is a solid architectural improvement that successfully reduces coupling between Scorpio and Ceres. The refactoring is clean, focused, and follows Rust best practices. However, there are issues that need attention:

Must Fix Before Merge:

1. 🔴 Critical: Edition "2024" doesn't exist - must fix in api-model/Cargo.toml, mono/Cargo.toml, and ceres/Cargo.toml
2. 📝 Minor: Formatting inconsistency in scorpio/Cargo.toml

Recommended for Follow-up:

3. ⚠️ Add documentation (package description, struct docs)
4. ⚠️ Add tests for the new crate
5. ⚠️ Clarify or improve the status field design
6. ⚠️ Add a PR description

Recommendation: The edition issue is a blocker and must be fixed before merging. The formatting issue should also be corrected. Documentation and tests can be added in a follow-up PR if time is constrained, though they would significantly improve the crate's quality.

---