feat(gnoweb): open render on package-name click, add Browse link in explorer#5966
Open
moul wants to merge 2 commits into
Open
feat(gnoweb): open render on package-name click, add Browse link in explorer#5966moul wants to merge 2 commits into
moul wants to merge 2 commits into
Conversation
Collaborator
🛠 PR Checks Summary🔴 Changes related to gnoweb must be reviewed by its codeowners Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🔴 Changes related to gnoweb must be reviewed by its codeowners ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
In the gnoweb explorer/paths-list view (e.g. a user/namespace package listing like
/r/g1.../), clicking a package name previously opened the directory listing ({{ .Link }}/, trailing slash), while the realm render was demoted to a small secondary Open button on the right.This flips the primary intent to match user expectation:
{{ .Link }}, same target as "Open").{{ .Link }}/) added to the right-side group, right after "Open", so the directory listing is still one click away.Right-side group in explorer mode is now:
Open,Browse,Source,Action(Open/Actionstill hidden for pure/p/packages;Browsealways shown).Only the explorer branch of
renderDirchanges — the directory-mode reuse (source-file listing) is gated behindIsExplorerand its main link never appended the trailing slash, so it's unaffected.Changes
gno.land/pkg/gnoweb/components/views/directory.html— main entry link now targets the render; addBrowseinline button.gno.land/pkg/gnoweb/handler_http_test.go— newTestHTTPHandler_ExplorerPathsListBrowseasserting the link targets (name→render, Browse→/, Open/Source/Action).gno.land/adr/prxxxx_gnoweb_explorer_browse_link.md— ADR.Testing
All pass.
AI-assisted (Claude); reviewed by @moul.