Skip to content

feat(gnoweb): open render on package-name click, add Browse link in explorer#5966

Open
moul wants to merge 2 commits into
masterfrom
claude/gnoweb-package-path-nav-0d11f4
Open

feat(gnoweb): open render on package-name click, add Browse link in explorer#5966
moul wants to merge 2 commits into
masterfrom
claude/gnoweb-package-path-nav-0d11f4

Conversation

@moul

@moul moul commented Jul 15, 2026

Copy link
Copy Markdown
Member

Summary

In the gnoweb explorer/paths-list view (e.g. a user/namespace package listing like /r/g1.../), clicking a package name previously opened the directory listing ({{ .Link }}/, trailing slash), while the realm render was demoted to a small secondary Open button on the right.

This flips the primary intent to match user expectation:

  • Package name → the realm render ({{ .Link }}, same target as "Open").
  • New Browse inline button ({{ .Link }}/) added to the right-side group, right after "Open", so the directory listing is still one click away.

Right-side group in explorer mode is now: Open, Browse, Source, Action (Open/Action still hidden for pure /p/ packages; Browse always shown).

Only the explorer branch of renderDir changes — the directory-mode reuse (source-file listing) is gated behind IsExplorer and its main link never appended the trailing slash, so it's unaffected.

Changes

  • gno.land/pkg/gnoweb/components/views/directory.html — main entry link now targets the render; add Browse inline button.
  • gno.land/pkg/gnoweb/handler_http_test.go — new TestHTTPHandler_ExplorerPathsListBrowse asserting the link targets (name→render, Browse→/, Open/Source/Action).
  • gno.land/adr/prxxxx_gnoweb_explorer_browse_link.md — ADR.

Testing

go test ./gno.land/pkg/gnoweb/...

All pass.

AI-assisted (Claude); reviewed by @moul.

@github-actions github-actions Bot added 📦 ⛰️ gno.land Issues or PRs gno.land package related 🌍 gnoweb Issues & PRs related to gnoweb and render labels Jul 15, 2026
@davd-gzl davd-gzl self-requested a review July 15, 2026 16:38
@Gno2D2 Gno2D2 requested review from alexiscolin and gfanton July 15, 2026 16:38
@Gno2D2

Gno2D2 commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

🛠 PR Checks Summary

🔴 Changes related to gnoweb must be reviewed by its codeowners

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Changes related to gnoweb must be reviewed by its codeowners

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Changes related to gnoweb must be reviewed by its codeowners

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 A changed file matches this pattern: ^gno.land/pkg/gnoweb/ (filename: gno.land/pkg/gnoweb/components/views/directory.html)

Then

🔴 Requirement not satisfied
└── 🔴 Or
    ├── 🔴 Or
    │   ├── 🔴 And
    │   │   ├── 🔴 Pull request author is user: alexiscolin
    │   │   └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED")
    │   └── 🔴 And
    │       ├── 🔴 Pull request author is user: gfanton
    │       └── 🔴 This user reviewed pull request: alexiscolin (with state "APPROVED")
    └── 🔴 And
        ├── 🟢 Not (🔴 Pull request author is user: alexiscolin)
        ├── 🟢 Not (🔴 Pull request author is user: gfanton)
        └── 🔴 Or
            ├── 🔴 This user reviewed pull request: alexiscolin (with state "APPROVED")
            └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED")

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@davd-gzl davd-gzl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image Image

@jefft0 jefft0 added the a/ux User experience, product, marketing community, developer experience team label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a/ux User experience, product, marketing community, developer experience team 🌍 gnoweb Issues & PRs related to gnoweb and render 📦 ⛰️ gno.land Issues or PRs gno.land package related

Projects

Status: 📥 Inbox

Development

Successfully merging this pull request may close these issues.

4 participants