Fix missing Infinity/NaN handling in bindings generator - #2030
Open
aaronfranke wants to merge 1 commit into
Open
Fix missing Infinity/NaN handling in bindings generator#2030aaronfranke wants to merge 1 commit into
aaronfranke wants to merge 1 commit into
Conversation
dsnopek
reviewed
Jul 26, 2026
|
|
||
| result.append("") | ||
| result.append("#include <godot_cpp/core/defs.hpp>") | ||
| result.append("#include <godot_cpp/core/math_defs.hpp>") |
Collaborator
There was a problem hiding this comment.
I'm a little unsure about including this in every header for builtin classes.
Although, I guess we are already including it pretty widely, given that it's included in math.hpp which is included in some variant type headers (ex vector2.hpp) which are included all over.
If it weren't a big mess (which it probably would be), it'd be nice to be more targeted about this.
Member
Author
There was a problem hiding this comment.
What would the alternative be? Directly using <limits>?
dsnopek
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bindings_generator.pyscript in godot-cpp fails to handle default values of Infinity or NaN:Apparently Godot doesn't have either of these as default values in the normal engine, so the problem didn't occur before.
This PR adds a remapping to
Math::INFandMath::NaN, which requires including themath_defs.hppheader: https://github.com/godotengine/godot-cpp/blob/master/include/godot_cpp/core/math_defs.hpp