strconv: document that an overflowing prefix reports ErrRange#80353
Open
soreavis wants to merge 1 commit into
Open
strconv: document that an overflowing prefix reports ErrRange#80353soreavis wants to merge 1 commit into
soreavis wants to merge 1 commit into
Conversation
ParseInt and ParseUint stop reading s as soon as they detect the value is out of range and return ErrRange at that point, so trailing invalid digits are never examined. The doc says a string containing invalid digits reports ErrSyntax, which does not hold when the numeric prefix overflows first. Document the current behavior rather than change it, as suggested on the issue. Fixes golang#78546
Contributor
|
This PR (HEAD: 39e3d1c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/799280. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseInt and ParseUint stop reading s as soon as they detect the value
is out of range and return ErrRange at that point, so trailing invalid
digits are never examined. The doc says a string containing invalid
digits reports ErrSyntax, which does not hold when the numeric prefix
overflows first.
Document the current behavior rather than change it, as suggested on
the issue.
Fixes #78546