Skip to content

strconv: document that an overflowing prefix reports ErrRange#80353

Open
soreavis wants to merge 1 commit into
golang:masterfrom
soreavis:strconv-errrange-doc
Open

strconv: document that an overflowing prefix reports ErrRange#80353
soreavis wants to merge 1 commit into
golang:masterfrom
soreavis:strconv-errrange-doc

Conversation

@soreavis

Copy link
Copy Markdown
Contributor

ParseInt and ParseUint stop reading s as soon as they detect the value
is out of range and return ErrRange at that point, so trailing invalid
digits are never examined. The doc says a string containing invalid
digits reports ErrSyntax, which does not hold when the numeric prefix
overflows first.

Document the current behavior rather than change it, as suggested on
the issue.

Fixes #78546

ParseInt and ParseUint stop reading s as soon as they detect the value
is out of range and return ErrRange at that point, so trailing invalid
digits are never examined. The doc says a string containing invalid
digits reports ErrSyntax, which does not hold when the numeric prefix
overflows first.

Document the current behavior rather than change it, as suggested on
the issue.

Fixes golang#78546
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 39e3d1c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/799280.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

strconv: ParseUint reports ErrRange instead of ErrSyntax

2 participants