Stop calling google_common_workspace_rules(). - #1939
Closed
copybara-service[bot] wants to merge 1 commit into
Closed
Stop calling google_common_workspace_rules().#1939copybara-service[bot] wants to merge 1 commit into
google_common_workspace_rules().#1939copybara-service[bot] wants to merge 1 commit into
Conversation
The only parts of bazel-common that we need are rule definitions like `javadoc_library`, not [the targets that `google_common_workspace_rules` creates](https://github.com/google/bazel-common/blob/9f8175287d46cdd21accb4b504a612b44c0f0564/workspace_defs.bzl#L59). (This _might_ have been the case from the beginning in cl/421862373, since that CL set up `//third_party` locally to Guice.) And calling `google_common_workspace_rules()` leads to trouble under macos-latest (as previously in 1701108): ``` ERROR: /Users/runner/work/guice/guice/WORKSPACE:26:30: fetching android_sdk_repository rule //external:androidsdk: Android SDK api level 34 was requested but it is not installed in the Android SDK at /Users/runner/Library/Android/sdk. The api levels found were [36, 35]. Please choose an available api level or install api level 34 from the Android SDK Manager. ERROR: Analysis of target '//tools:osgi_wrapper' failed; build aborted: Android SDK api level 34 was requested but it is not installed in the Android SDK at /Users/runner/Library/Android/sdk. The api levels found were [36, 35]. Please choose an available api level or install api level 34 from the Android SDK Manager. ``` RELNOTES=n/a PiperOrigin-RevId: 957302488
Member
|
And I see that I'm wrong: We need to pull in the targets because they're used by the rule definitions: The right way to go here will be to update to a new version of bazel-common (and deal with any fallout from that). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop calling
google_common_workspace_rules().The only parts of bazel-common that we need are rule definitions like
javadoc_library, not the targets thatgoogle_common_workspace_rulescreates. (This might have been the case from the beginning in cl/421862373, since that CL set up//third_partylocally to Guice.)And calling
google_common_workspace_rules()leads to trouble under macos-latest (as previously in 1701108):RELNOTES=n/a