Skip to content

fix(release): add Version.java as extra files in release-please #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegomarquezp merged 1 commit into from
Apr 2, 2026
Merged

fix(release): add Version.java as extra files in release-please #12617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@
"packages": {
".": {
"extra-files": [
{
"type": "generic",
"path": "java-*/**/Version.java",
"glob": true
},
{
"type": "generic",
"path": "sdk-platform-java/java-showcase*/Version.java",
"glob": true
},
Comment on lines +11 to +20

@gemini-code-assist gemini-code-assist Bot Apr 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation in the newly added blocks uses a mix of tabs and spaces, which is inconsistent with the 2-space indentation used in the rest of the file. Additionally, please ensure that configuration for files within submodules is placed in the root package's extra-files section, as release-please does not check for configuration within submodules. Finally, the PR title mentions 'renovate config', but these changes are for release-please. Updating the title will ensure the generated changelog is accurate.

  {
    "type": "generic",
    "path": "java-*/**/Version.java",
    "glob": true
  },
  {
    "type": "generic",
    "path": "sdk-platform-java/java-showcase*/Version.java",
    "glob": true
  }
References
  1. In release-please-config.json, configuration for files within submodules should be placed in the root package's extra-files section, as release-please does not check for configuration within submodules.

@ldetmer ldetmer Apr 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I didn't have to add the extra metadata type and glob for it to work for bigquery

@blakeli0 blakeli0 Apr 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR title mentions 'renovate config', but these changes are for release-please

This is valid. @diegomarquezp Can you please update the PR title before merging?

@diegomarquezp diegomarquezp Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I didn't have to add the extra metadata type and glob for it to work for bigquery

I wanted to cover all Version.java files generated in google-cloud-java.

@diegomarquezp diegomarquezp Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR title mentions 'renovate config', but these changes are for release-please

This is valid. @diegomarquezp Can you please update the PR title before merging?

Done

".github/workflows/generated_files_sync.yaml",
".github/workflows/hermetic_library_generation.yaml",
"sdk-platform-java/WORKSPACE",
Expand Down
Loading