pubsub: make Publisher log less chatty - #1749
Merged
Merged
Conversation
googlebot
added
the
cla: yes
|
Changes Unknown when pulling b28bffa on pongad:publisher-log-level into ** on GoogleCloudPlatform:master**. |
| setupDurationBasedPublishAlarm(); | ||
| } else if (currentAlarmFuture != null) { | ||
| logger.log(Level.INFO, "Cancelling alarm"); | ||
| logger.log(Level.FINER, "Cancelling alarm, no more messages"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lesv
approved these changes
Mar 14, 2017
lesv
left a comment
lesv
left a comment
Contributor
There was a problem hiding this comment.
@jabubake @garrettjonesgoogle @pongad I find I disagree w/ Garrett -- What I'd really want in many of these places is a logOnce primitive, but that's not part of any of the loggers.
| setupDurationBasedPublishAlarm(); | ||
| } else if (currentAlarmFuture != null) { | ||
| logger.log(Level.INFO, "Cancelling alarm"); | ||
| logger.log(Level.FINER, "Cancelling alarm, no more messages"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| if (bundleToSend != null) { | ||
| logger.log(Level.INFO, "Scheduling a bundle for immediate sending."); | ||
| logger.log(Level.FINER, "Scheduling a bundle for immediate sending."); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| if (hasBundlingBytes() && messageSize >= getMaxBundleBytes()) { | ||
| logger.log( | ||
| Level.INFO, "Message exceeds the max bundle bytes, scheduling it for immediate send."); | ||
| Level.FINER, "Message exceeds the max bundle bytes, scheduling it for immediate send."); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @Override | ||
| public void run() { | ||
| logger.log(Level.INFO, "Sending messages based on schedule."); | ||
| logger.log(Level.FINER, "Sending messages based on schedule."); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| if (!activeAlarm.getAndSet(true)) { | ||
| long delayThresholdMs = getBundlingSettings().getDelayThreshold().getMillis(); | ||
| logger.log(Level.INFO, "Setting up alarm for the next {0} ms.", delayThresholdMs); | ||
| logger.log(Level.FINER, "Setting up alarm for the next {0} ms.", delayThresholdMs); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM, since @lesv thinks |
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
* chore(main): release 3.21.2-SNAPSHOT * chore: generate libraries at Mon Jan 13 17:03:24 UTC 2025 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
chingor13
pushed a commit
that referenced
this pull request
Feb 24, 2026
…uth2-http to v1.35.0 (#1749)
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
* chore(main): release 3.21.2-SNAPSHOT * chore: generate libraries at Mon Jan 13 17:03:24 UTC 2025 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 12, 2026
…uth2-http to v1.35.0 (#1749)
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
…o v1.125.3 (#1749) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.125.3 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
…o v1.125.3 (#1749) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.125.3 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
May 2, 2026
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
…to v3.18.0 (googleapis#1749) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-monitoring-bom](https://togithub.com/googleapis/google-cloud-java) | `3.17.0` -> `3.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigtable). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40OC4yIiwidXBkYXRlZEluVmVyIjoiMzUuNDguMiJ9-->
](https://renovatebot.com){kind=link}
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
🤖 I have created a release *beep* *boop* --- ## [2.23.1](https://togithub.com/googleapis/java-bigtable/compare/v2.23.0...v2.23.1) (2023-05-11) ### Dependencies * Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.18.0 ([googleapis#1749](https://togithub.com/googleapis/java-bigtable/issues/1749)) ([d135454](https://togithub.com/googleapis/java-bigtable/commit/d135454a84746184c3019a6591ab64c70c3118d1)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.9.0 ([googleapis#1744](https://togithub.com/googleapis/java-bigtable/issues/1744)) ([216ec28](https://togithub.com/googleapis/java-bigtable/commit/216ec28edc555c35d237563ca400c3d4bae940b2)) * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.22 ([googleapis#1746](https://togithub.com/googleapis/java-bigtable/issues/1746)) ([d77f2c7](https://togithub.com/googleapis/java-bigtable/commit/d77f2c7f90aad105feb18792973fa3f1e535285a)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.22 ([googleapis#1747](https://togithub.com/googleapis/java-bigtable/issues/1747)) ([4a68b83](https://togithub.com/googleapis/java-bigtable/commit/4a68b8350a9316bd0f5b02def53857adf8dacfed)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1681.