security: strip Authorization and Cookie headers on cross-origin redirects - #2182
Open
insaf021 wants to merge 1 commit into
Open
security: strip Authorization and Cookie headers on cross-origin redirects#2182insaf021 wants to merge 1 commit into
insaf021 wants to merge 1 commit into
Conversation
insaf021
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpRequest now strips Authorization and Cookie headers before following cross-origin
redirects (different scheme, host, or port), preventing credential leakage.
Changes
HttpRequest.java: tracks original origin, clears Authorization/Cookie on origin change
between retries; handleRedirect() strips Cookie on cross-origin redirects using new
getEffectivePort()/isSameOrigin() helpers.
HttpRequestTest.java: adds tests for host/scheme/port changes and default-port
equivalence.
Opened an issue before writing code
Tests and linter pass
Code coverage does not decrease
Docs updated
Fixes #2181