security: disable XML DTD processing in XmlPullParser to prevent XXE - #2183
Open
insaf021 wants to merge 1 commit into
Open
security: disable XML DTD processing in XmlPullParser to prevent XXE#2183insaf021 wants to merge 1 commit into
insaf021 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Xml#createParser() did not disable FEATURE_PROCESS_DOCDECL, leaving the XmlPullParser
vulnerable to XML External Entity (XXE) injection when parsing attacker-influenced content.
Changes
Xml.java: set FEATURE_PROCESS_DOCDECL=false immediately after parser creation, with a
graceful try/catch fallback for parser implementations that don't support the feature.
XmlTest.java: added testCreateParser_disablesDocDecl to verify DTD entity content is
not resolved (or that the parser throws, both are safe outcomes).
Opened an issue before writing code
Tests and linter pass
Code coverage does not decrease
Docs updated
Fixes #2179 ☕️