security: validate header names and values to prevent CRLF injection - #2184
Open
insaf021 wants to merge 1 commit into
Open
security: validate header names and values to prevent CRLF injection#2184insaf021 wants to merge 1 commit into
insaf021 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpHeaders#addHeader now rejects header names/values containing CR (\r) or LF (\n),
throwing IllegalArgumentException on CRLF injection attempts — prevents HTTP Header
Injection and Response Splitting.
Changes
HttpHeaders.java: added CRLF validation in addHeader() after computing stringValue.
HttpHeadersTest.java: added testSerializeHeaders_crlfInjectionInName and
testSerializeHeaders_crlfInjectionInValue.
Opened an issue before writing code — Core: Validate header names and values to prevent CRLF injection #2180
Tests and linter pass
Code coverage does not decrease (2 new tests added)
Docs updated
Fixes #2180 ☕️