refactor(network/shape): de-duplicate the traffic-shaper engine and fix interactive daemon block-node wiring

[alex-au]

Description

Behavior-preserving cleanup of the traffic-shaper engine (internal/network/shape), which accumulated duplication and dead code as the feature landed across ~10 PRs, plus a fix for a real bug in the interactive daemon installer. Net −116 lines; no functional change to the shaping engine.

The daemon fix addresses a latent bug: the interactive daemon service install path built the block-node component without its kubeconfig or orbit namespace, guarded by a stale "traffic-shaper is stubbed" comment. The monitor is fully wired now, so that path produced an incomplete config versus block node install and daemon_offer.go, which both set these fields. The bn-orbit prompt and BNOrbit target already existed but were never hooked up.

Files changed

File	Change
internal/network/shape/defaults.go (new)	Data-driven egress/ingress default profiles + shared buildDefaultConfig
internal/network/shape/tc.go (new)	Single build-tag-free TCRunner interface declaration
internal/network/shape/manager.go	Share one provisionDefaults; drop twin default*Config + redundant exported RenderAndApplyEgress; use validateClassFields
internal/network/shape/validate.go	Add validateClassFields + sumParseableRatesBps
internal/network/shape/override.go	Use the shared validators; remove dead ClassDirection
internal/network/shape/registry.go	Generic writeConfigJSON/readConfigJSON/removeConfigFile behind the device/class wrappers
internal/network/shape/tc_linux.go, tc_other.go	Remove the now-shared TCRunner interface declaration
internal/ui/prompt/daemon.go	Wire block-node kubeconfig + orbit prompt (bug fix)

Review guide

Checklist:

• defaults.go:64 buildDefaultConfig — verify ceilFull classes emit the trunk rate verbatim (e.g. 1gbit, not 1000mbit) and percentage classes match the previous mbps*pct/100 maths (egress partner 40/70, public 30/70, reserve 30/trunk; ingress 80/10/10 all ceil=trunk).
• manager.go provisionDefaults — egress passes an afterWrite that renders+applies the boot script; ingress passes nil (config only, no boot script). Both still run under withLock.
• validate.go validateSumRates — the "device rate unparseable" and "new rate unparseable" early-return skips are preserved (guards the legacy SPEED path, intentionally untouched here).
• registry.go — error-message wording changed (no test asserts it); behavior identical, mkdir target unchanged.
• daemon.go — Step 4/5 mirror the consensus-node wiring; bn-orbit is prompted only when the block-node component is selected.

Tests:

go test ./internal/network/shape/... ./internal/blocknode/shaper/... ./internal/ui/prompt/...
task lint

All pass; golangci-lint reports 0 issues; go vet clean.

Not in scope

The legacy "SPEED" sysfs-fallback render path is deliberately left untouched — it is still reachable via network shape delete --device egress and legacy on-disk registries, and retiring it needs a DeleteDevice(egress) redesign first (tracked in #946). Two follow-up structural refactors are filed separately: #946 (collapse the render/apply pipeline + single-source tc encoding) and #947 (unify the firewall/traffic-shaping gated-feature wiring).

Related Issues

• Closes refactor(network/shape): de-duplicate the traffic-shaper engine and fix interactive daemon block-node wiring #948

[swirlds-automation]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[Copilot]

Pull request overview

This PR cleans up internal/network/shape by consolidating duplicated logic (default profile construction, per-class validation, and registry JSON CRUD) while keeping behavior stable, and fixes the interactive daemon service install prompts to correctly populate block-node kubeconfig + orbit namespace needed by the traffic-shaper monitor.

Changes:

• Deduplicates default egress/ingress profile generation via a shared, data-driven buildDefaultConfig.
• Centralizes class-field validation (rate/ceil/prio) and rate-summing logic to ensure consistent enforcement across verbs.
• Fixes interactive daemon installer wiring for the block-node component (sets kubeconfig and prompts for bn-orbit when selected).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/network/shape/defaults.go	Introduces data-driven default profiles and a shared default-config builder.
internal/network/shape/manager.go	Replaces duplicated default-provisioning paths with a shared provisionDefaults; removes redundant exported wrapper.
internal/network/shape/override.go	Removes dead ClassDirection; reuses shared validators and shared rate-summing helper.
internal/network/shape/registry.go	Consolidates device/class registry JSON read/write/remove into generic helpers.
internal/network/shape/tc.go	Moves TCRunner interface into a build-tag-free file shared by linux/non-linux implementations.
internal/network/shape/tc_linux.go	Removes duplicate TCRunner declaration (now shared from tc.go).
internal/network/shape/tc_other.go	Removes duplicate TCRunner declaration (now shared from tc.go).
internal/network/shape/validate.go	Adds validateClassFields and sumParseableRatesBps to deduplicate validation and sum checking.
internal/ui/prompt/daemon.go	Fixes interactive daemon install prompts to wire BN kubeconfig and prompt for BN orbit when selected.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.