Skip to content

NB Demo Video Embedded Into Log In Page - #155

Merged
JumanaFM merged 1 commit into
haystack:summer21from
KMitzel:video-embed
Jul 5, 2021
Merged

NB Demo Video Embedded Into Log In Page#155
JumanaFM merged 1 commit into
haystack:summer21from
KMitzel:video-embed

Conversation

@KMitzel

@KMitzel KMitzel commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

NB Demo Video now embedded into log in page below the create an account section

Features:

  • Adjusts as the size of the window is increased and decreased
  • Link of youtube video is embedded and loads properly
  • Front page scrollable when video overlaps a bit

Changes:

  • frontend: added new container to hold iframe of video for front page

Normal overview
Normal Size overview

Smaller sized screen
Smaller screen view plus scrollbar

Skinny screen
Skinny Screen View

@KMitzel

KMitzel commented Jun 29, 2021

Copy link
Copy Markdown
Contributor Author

Only current concern I have is the formatting on larger screens, I'm not sure if the size adjust properly or not

@JumanaFM
JumanaFM changed the base branch from master to develop June 29, 2021 18:42
@JumanaFM
JumanaFM changed the base branch from develop to summer21 July 5, 2021 22:05
@JumanaFM
JumanaFM merged commit 0ffaefe into haystack:summer21 Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants