Fix: Avoid end_offset overflows - #1
Merged
Merged
Conversation
Owner
|
Merging with errors, RuboCop offenses will be fixed later on. Thanks @ofeefo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a potential bug in the YAML editor by ensuring that the YAML data always ends with a trailing newline, and adds a regression test to prevent end offset overflow errors when updating YAML values.
Bug fix for YAML data handling:
@datastring inPatchYAML::Editor#reloadalways ends with a newline character to prevent parsing issues, which could lead to end offset errors. (lib/patchyaml/editor.rb)Testing and regression prevention:
regression_spec.rbto verify that updating a YAML structure does not cause an end offset overflow, and that the output remains correct. (spec/regression_spec.rb)