Skip to content

Install fish shell completions via pip#1899

Open
yoshibase wants to merge 1 commit into
httpie:masterfrom
yoshibase:fix/issue-912-fish-completions
Open

Install fish shell completions via pip#1899
yoshibase wants to merge 1 commit into
httpie:masterfrom
yoshibase:fix/issue-912-fish-completions

Conversation

@yoshibase

@yoshibase yoshibase commented Jul 15, 2026

Copy link
Copy Markdown

Summary

Fixes #912.

Install HTTPie's existing Fish completions through Python wheels and source distributions, so Fish discovers completions for the http command without downstream package-specific copying.

Changes

  • Add share/fish/vendor_completions.d to setup.cfg data files
  • Install the canonical extras/httpie-completion.fish unchanged
  • Add a command-named http.fish loader that sources the canonical definitions, avoiding a duplicated completion script
  • Include both files in the source distribution manifest

Test plan

  • python -m build --sdist --wheel
  • Wheel contains share/fish/vendor_completions.d/http.fish
  • Wheel contains share/fish/vendor_completions.d/httpie-completion.fish
  • Source distribution contains both source files

@yoshibase
yoshibase force-pushed the fix/issue-912-fish-completions branch 3 times, most recently from a96871e to 4484e2e Compare July 25, 2026 04:11
Install a command-named Fish loader alongside the canonical completion definitions without duplicating the completion script.

Fixes httpie#912
@yoshibase
yoshibase force-pushed the fix/issue-912-fish-completions branch from 4484e2e to 1a5b3e5 Compare July 25, 2026 04:18
@yoshibase

Copy link
Copy Markdown
Author

CI note after the clean rebuild: the current PR is only the 3 packaging/completion files, and the wheel + sdist build succeeds with both Fish files in share/fish/vendor_completions.d.

The remaining red jobs reproduce on upstream master (for example run 28435490851): Big5 detection assertions, Python 3.7 unavailable on Ubuntu 24.04, argparse formatting drift, and an unrelated urllib3 digest-auth error. None touches this PR's files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fish shell completions

1 participant