Extract git-repo ingestion into a standalone /ingest-course-repo skill - #13
Merged
Conversation
PR #2 bolted an optional repo-ingestion step onto /generate-spec. The capability is useful; the placement was not. It forced generate-spec to carve out an exception in its own "Don't write to materials/" rule, and made a single-purpose skill do two jobs. Every other skill in the loop is single-purpose and hands off. This extracts it rather than reverting it: the script moves with its history (git mv), the prose moves largely intact, and the shortcut keeps working behind its own front door. /generate-spec is materials -> spec.md again, with a flat write invariant; /ingest-course-repo is the sole writer into materials/. Two bugs fixed on the way: - Silent clobber. The prescribed --out was byte-identical to the name of a hand-downloaded context dump (<course>-context.md), and the script overwrites without asking. Output now lands in materials/notebooks/from-repo/, so the two coexist. - The target repo was un-ingestible. deeplearningai-eng/courses is a 3.4 GB monorepo holding ~260 courses with no path scoping in the script, so ingesting it would have cloned everything and merged every course into one context file. ingest_repo.py gains an optional --subdir that scopes discovery and switches the clone to --filter=blob:none --sparse with GIT_LFS_SKIP_SMUDGE=1. Pulling course_10 now transfers 8.7 MB in ~8s. Omitted, behaviour is byte-identical to before, so standalone course repos are unaffected. The skill parses a GitHub tree URL into repo + --ref + --subdir, and refuses the bare monorepo root with a pointer to browse for the course folder. Framing throughout is corrected from PR #2's "skip the manual notebook download" to what it actually is: an optional supplement that adds the course's real code and helper.py on top of the site download, which remains the main path. Verified: backward compatibility against the pre-change script on a local fixture (byte-identical); subdir scoping; sparse clone size; bad-subdir and transcripts-path guards; no clobber of a hand-downloaded file; tree-URL parse producing the same output as hand-typed flags; both refusal paths firing without invoking git. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverses the coupling introduced in #2 by extracting it rather than reverting it.
/generate-specgoes back to being purely materials →spec.md; repo ingestion becomes its own skill.Not a
git revertof d62df53 — #3/#6/#7 rewrotegenerate-spec/SKILL.mdafterwards, and a revert would clobber the guide-deference wording. The script moves viagit mv, so its history follows.Why
/generate-spechad to carve out an exception in its own## Don'tlist — "Don't write tomaterials/… except the Step 2 ingest script" — an invariant with an exception inside the skill meant to honour it. It also made a single-purpose skill do two jobs, which nothing else in the loop does (/new-coursedeliberately doesn't generate the spec).After:
/generate-spechas a flatDon't write to builds/, evals/, or materials/, and/ingest-course-repois the sole writer intomaterials/.Two bugs found and fixed
Silent clobber. The
--outpath #2 prescribed (materials/notebooks/<course>-context.md) is byte-identical to the name of a hand-downloaded context dump — confirmed against the eval fixtures — andout.write_textoverwrites without asking. Output now goes tomaterials/notebooks/from-repo/, so both coexist.The target repo couldn't be ingested at all.
deeplearningai-eng/coursesis a private 3.4 GB monorepo, 262 root entries, onecourse_<id>/per course, git-LFS-backed.find_notebooks/find_helpersrglobfrom the clone root with no scoping, so pointing the skill at it would have cloned 3.4 GB and merged ~260 courses into one context file.ingest_repo.pygains an optional--subdirthat scopes discovery and switches the clone to--filter=blob:none --sparsewithGIT_LFS_SKIP_SMUDGE=1:course_10ingestOmitted, behaviour is byte-identical to today — standalone single-course repos are unaffected.
Interface
The skill parses the tree URL into repo +
--ref+--subdir. A bare monorepo root is refused with a pointer to browse for the course folder; any other bare root proceeds normally.Framing correction
#2's copy sold this as a way to "skip the manual notebook download". It isn't a replacement — it's an optional supplement that adds the course's real code and
helper.pyon top of the site download, which stays the main path. Rewritten innew-course/SKILL.md,README.md, and the new skill;/new-course's item 4 handoff is untouched, with the ingest trailing as a clearly subordinate item 5.Verified
--subdir: byte-identical outputhelper.pyconflict;--subdirgives 1 + 0course_10checked out)--subdir→ exit 1, no partial file;--outintotranscripts/→ exit 1Not included: the untracked
.agents/Codex mirror was updated locally for parity but is deliberately out of this PR.🤖 Generated with Claude Code