[TP] Keep optimizer state aligned after parameter swaps - #4141
Open
sdjasj wants to merge 1 commit into
Open
Conversation
sdjasj
marked this pull request as ready for review
August 1, 2026 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keeps optimizer state keyed by the active parameters when tensor parallel preparation replaces model parameters with DTensors.
Optimizers such as Adagrad initialize per-parameter state in their constructor. TP preparation previously updated only
param_groups, leaving the state dictionary keyed by the original parameters. PyTorch then raised aKeyErrorwhen serializing the inconsistent optimizer.AcceleratedOptimizer._switch_parametersnow moves any existing state to the replacement parameter, and TP preparation uses that state-aware path. The regression test verifies both the state keys and values before callingstate_dict().Fixes #3855
Validation