Add sigmas to pipelines using FlowMatch - #10116
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
Dec 4, 2024
sayakpaul
left a comment
sayakpaul
left a comment
Member
There was a problem hiding this comment.
Thanks! My only comment is that this could be a breaking change and we might want to consider a deprecation. Or maybe that's a stretch.
| prompt: Union[str, List[str]] = None, | ||
| negative_prompt: Union[str, List[str]] = None, | ||
| num_inference_steps: int = 50, | ||
| timesteps: List[int] = None, |
Member
There was a problem hiding this comment.
Even though these are non-functional but isn't this a breaking change? If so, maybe we should deprecate (with a short cycle, for sure)?
Contributor
Author
Collaborator
There was a problem hiding this comment.
it doesn't because the flow match scheduler does not accept timesteps
thanks for the fix @hlky!
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of the fixes for #10113.
Pipelines in this PR all use FlowMatch scheduler which does not currently support passing timesteps so the timesteps argument is non-functional, we replace timesteps argument with
sigmaswhich is currently supported by the scheduler. See #10080 #10112 for example use case of passingsigmas.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.