Skip to content

[refactor] DiffusionPipeline.download - #9557

Merged
yiyixuxu merged 10 commits into
mainfrom
refactor-download
Oct 17, 2024
Merged

[refactor] DiffusionPipeline.download#9557
yiyixuxu merged 10 commits into
mainfrom
refactor-download

Conversation

@a-r-r-o-w

Copy link
Copy Markdown
Contributor

What does this PR do?

Part 2 following #8967

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yiyixuxu @sayakpaul

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Overall, I like the direction!

Comment thread src/diffusers/pipelines/pipeline_loading_utils.py Outdated
return custom_components, folder_names


def _get_ignore_patterns(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Comment thread src/diffusers/pipelines/pipeline_utils.py Outdated
Comment thread src/diffusers/pipelines/pipeline_utils.py
Comment thread src/diffusers/pipelines/pipeline_utils.py
Comment thread src/diffusers/pipelines/pipeline_utils.py Outdated
@yiyixuxu
yiyixuxu requested a review from DN6 October 16, 2024 03:56

@yiyixuxu yiyixuxu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yiyixuxu
yiyixuxu merged commit 5704376 into main Oct 17, 2024
@yiyixuxu
yiyixuxu deleted the refactor-download branch October 17, 2024 22:38
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* update

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants