fix(ci): build svalinn binary from the real entrypoint (MVP gateway)#54
Merged
Conversation
The "Build Binaries" job — and the src/deno.json build/dev/start/compose tasks — still pointed at src/main.ts and src/compose/cli.ts, which were never created after the .res->.affine migration. So the job failed on every run with "Cannot find module .../src/main.ts", keeping main red. (The typecheck job was already fixed to check the real entrypoint; the build job and deno tasks were missed.) The only Deno-compilable entrypoint today is the MVP gateway, tools/mvp/svalinn_gateway.ts — the same file the typecheck job checks. - src/deno.json: point build/dev/start at ../tools/mvp/svalinn_gateway.ts and drop the dead build:compose and compose tasks (no compose CLI exists). The build task is now the single source of truth for the entrypoint. - ci.yml: the Build Binaries job runs `deno task build` instead of duplicating a stale command, so CI and local builds can never drift from deno.json again. Verified with deno 2.9.0: `deno task build` produces a working dist/svalinn that boots the HTTP gateway (listens on :8000); `deno fmt --check`, `deno lint`, and `deno task check` all pass. deno.lock is left untouched on purpose — the test jobs resolve imports the gateway doesn't, so it must keep the full graph. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011z2t8zAxfcCNLJzU7YdpBQ
hyperpolymath
marked this pull request as ready for review
June 27, 2026 09:21
hyperpolymath
enabled auto-merge (squash)
June 27, 2026 09:21
hyperpolymath
disabled auto-merge
June 27, 2026 09:22
hyperpolymath
enabled auto-merge (squash)
June 27, 2026 09:22
hyperpolymath
disabled auto-merge
June 27, 2026 09:24
hyperpolymath
enabled auto-merge (squash)
June 27, 2026 09:24
…ob conflict #55 (inline deno compile) merged to main while this branch (#54) refactors the same Build Binaries job to 'deno task build'. Resolved by keeping #54's single-source-of-truth design AND #55's correctness: - ci.yml: build job runs 'deno task build' (working-directory: src); upload path corrected to src/dist/ (where that task emits the binary). - src/deno.json: dev/start/build tasks now bake the gateway's full runtime permissions (net/read/write/env/run) — the --allow-write/--allow-run that #55 established are no longer dropped. Lockfiles left untouched (test jobs need the full graph). Verified with deno 2.9.0: 'deno task build' produces src/dist/svalinn (rc=0); deno fmt --check and YAML parse clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XhuUim2UaLDziQRrFgtBTJ
hyperpolymath
disabled auto-merge
June 27, 2026 10:04
|
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The
Build BinariesCI job has been failing on every run with:Root cause: after the
.res → .affinemigration,src/holds AffineScript —src/main.tsandsrc/compose/cli.tswere never created. Thetypecheckjob was already fixed to check the real entrypoint (tools/mvp/svalinn_gateway.ts), but thebuildjob and thesrc/deno.jsontasks were missed and still pointed at the non-existent files. This is the pre-existing red I flagged when reconciling #52.The fix (root cause, single source of truth)
src/deno.json— pointbuild/dev/startat../tools/mvp/svalinn_gateway.ts(the only Deno-compilable entrypoint, and the same filetypecheckchecks). Drop the deadbuild:compose/composetasks — there is no compose CLI. Thebuildtask is now the single definition of the entrypoint..github/workflows/ci.yml— theBuild Binariesjob runsdeno task buildinstead of duplicating a stale raw command, so CI and local builds can never drift fromdeno.jsonagain. When the AffineScript/Ephapax app gains a compilable entrypoint, updating the one task updates both.deno.lockis intentionally left untouched — the test jobs resolve imports the gateway doesn't (@std/yaml,@std/cli, …), so the full graph must stay.Verification (local, deno 2.9.0)
Run against the actual tree, not eyeballed:
deno task build(the exact CI command)dist/svalinn./dist/svalinn:8000deno fmt --check(incl. editeddeno.json)deno lintdeno task check(
deno compilefetches itsdenortbase fromdl.deno.land, which is blocked in my sandbox; I verified by pointingDENORT_BINat thedenortasset from GitHub Releases. CI has normal network, so the job needs no such workaround.)Out of scope (flagged, not fixed)
README.adoc/EXPLAINME.adoc/TOPOLOGY.mdstill describe the oldsrc/main.tsgateway and asvalinn-composeCLI. That's stale documentation from the pre-migration architecture — a separate doc-accuracy pass, not part of getting CI green.🤖 Generated with Claude Code
Generated by Claude Code