Rework ExecutorService for improved performance - #1
Merged
Conversation
jungle-bunny
force-pushed
the
fix-executor
branch
from
July 22, 2021 20:23
a35ce1c to
3ddc484
Compare
jungle-bunny
force-pushed
the
fix-executor
branch
from
July 23, 2021 02:36
c1a15fa to
96f88f7
Compare
Collaborator
|
Thank you! I’ll try to create a test jar to get this tested by enough people to get ready for release in 1496. |
Collaborator
|
Looks good to me. A test jar is at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the ExecutorService for fetching was blocking (not truly parallelized). This fixes the issue for greatly increased performance, especially at higher power levels.