Pass the strlen to the readCallback as was expected - #10
Merged
Conversation
Contributor
Author
|
I have no idea why php <7 is failing |
Contributor
Author
|
Ok turns out php <7 always reads the chunk size and does other magic in fread. |
3 tasks
icewind1991
reviewed
Feb 15, 2019
Owner
|
you can add a condition for the php version in the test case. As long as the callback actually gets the number of bytes read it doesn't matter that those values depend on php version |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So turns out I was to quick with #8
Fixed now
And adjusted the tests to actually check for this