Add PVC and volumeMounts for deployment#49
Merged
Conversation
nepalez
self-requested a review
September 24, 2021 18:20
Contributor
|
@phoenix-bjoern Thank you! Will look at it on the weekend |
nepalez
reviewed
Sep 27, 2021
nepalez
approved these changes
Sep 27, 2021
nepalez
added a commit
that referenced
this pull request
Sep 27, 2021
Add PVC and volumeMounts for deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up on issue #2. The PR allows to serve files from localy attached volume (e.g. NFS shares or RWX).
The PR provides configurations for persistence. When enabled a PVC will be created. Also an existing PVC can be used instead. The PVC will get defined as a volume in the imgproxy deployment and the PV will be mounted at the specified mountPath.
It makes sense to configure IMGPROXY_LOCAL_FILESYSTEM_ROOT separately in the
values.yaml: