#562 Support coverage tags in .md and .rst - #566
Merged
kaklakariada merged 36 commits intoJul 28, 2026
Merged
Conversation
added 26 commits
July 23, 2026 14:00
This simplifies adding already completed items
…n_and_restructuredtext # Conflicts: # .agents/skills/openfasttrace/SKILL.md # api/src/main/java/org/itsallcode/openfasttrace/api/importer/ImportEventListener.java # api/src/test/java/org/itsallcode/openfasttrace/api/importer/TestSpecificationListBuilder.java # doc/changes/changes_4.7.0.md # doc/spec/design.md # doc/spec/system_requirements.md # doc/user_guide.md # importer/gherkin/src/main/java/module-info.java # importer/gherkin/src/main/java/org/itsallcode/openfasttrace/importer/gherkin/GherkinLineConsumer.java # importer/gherkin/src/test/java/org/itsallcode/openfasttrace/importer/gherkin/GherkinImporterTest.java # importer/tag-importer-common/src/test/java/org/itsallcode/openfasttrace/importer/tag/common/TestDelegatingLineConsumer.java # importer/tag-importer-common/src/test/java/org/itsallcode/openfasttrace/importer/tag/common/TestLineReader.java # product/src/test/java/org/itsallcode/openfasttrace/importer/ImporterFactoryLoaderIT.java
redcatbear
requested changes
Jul 27, 2026
redcatbear
left a comment
redcatbear
left a comment
Collaborator
There was a problem hiding this comment.
Please remove support for the short tag format in Markdown / RST. This one is deprecated and makes the code unnecessarily complicated.
Co-authored-by: Sebastian Bär <rcb4gh@proton.me>
added 4 commits
July 27, 2026 12:51
…ucturedtext' of https://github.com/itsallcode/openfasttrace into feature/562_support_coverage_tags_in_markdown_and_restructuredtext
redcatbear
approved these changes
Jul 28, 2026
Comment on lines
+79
to
80
| } | ||
| this.stateMachine.step(this.currentContext.currentLine(), this.currentContext.nextLine()); |
Collaborator
There was a problem hiding this comment.
Correctness: I think this is an either-or situation. So the state machine step can go to the else path. I see no scenario where a coverage Tag candidate could trigger a valid transition.
Contributor
Author
There was a problem hiding this comment.
Adding an else block will break <!-- oft:off --> and <!-- oft:on --> tags in Markdown, Test TestMarkdownMarkupImporter.testDisablingMarkdownParsingForATextBlock would fail.
|
kaklakariada
deleted the
feature/562_support_coverage_tags_in_markdown_and_restructuredtext
branch
July 28, 2026 08:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #562