Fix jamulus/pollServerList reporting success on invalid directory address

[mcfnord]

Fixes #3818

The jamulus/pollServerList RPC handler set response["error"] when the directory address failed to parse, but then unconditionally set response["result"] = "ok" after the if/else. As a result, an invalid socket address was reported as success, with both "error" and "result" present in the response.

if ( NetworkUtil::ParseNetworkAddress ( ..., false ) )
{
    pClient->CreateCLReqServerListMes ( haDirectoryAddress );
    response["result"] = "ok";
}
else
{
    response["error"] = CRpcServer::CreateJsonRpcError ( ... );
}

response["result"] = "ok";   // <-- always ran, clobbering the error case

Fix

Remove the stray unconditional assignment. The success branch already sets result = "ok", so the handler now reports error on failure and result on success — matching the error-path idiom used by every other handler in this file.

Testing

• clang-format-14 clean
• Headless build + server smoke test (clean startup, clean SIGTERM)

[ann0see]

AI is probably still working...

[ann0see]

Testing should obviously test the JSON-RPC api...

[mcfnord]

AI is probably still working...

The Fable special ended, so today is Opus on X-High Effort. I saw a few examples today of Opus making small errors, but those probably indicate larger errors are more possible, including subtle errors. So in the most complicated instance, I asked Fable to review results.

[mcfnord]

Note

📡 STAND BY FOR AN LLM-AUTHORED MESSAGE.

@ann0see The requested change is in d90fbb6: the handler now uses the guard-clause / early-return style of the other methods in this file — invalid address sets response["error"] and returns, then the success path sets response["result"] = "ok" unconditionally. Ready for re-review whenever you have a moment.