Fix array handling in SchemaOf type - #1169
Merged
Merged
Conversation
- Move array before object so that inference works correctly - Include lazy as part of array type, to match the class definition
chasecaleb
force-pushed
the
fix-schemaof-type
branch
from
December 10, 2020 20:48
6019641 to
0a8baa7
Compare
Owner
|
huh TIL. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazyas part ofArraySchema's generic, to match the class definitionHere's a quick snippet that illustrates why 1 is necessary:
By the way, I noticed that eslint isn't checking the
$ExpectTypecomments intest/type.ts... I investigated it for a little bit, but ran into more problems so I gave up. You need to add--ext=.ts,.jswhen running eslint to make sure it checks the ts file, but then eslint started to give parser errors and I lost motivation. That's my excuse for not adding tests, sorry about that.