Potential fix for code scanning alert no. 2: Uncontrolled data used in path expression - #10
Merged
Conversation
…n path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/kelsoncm/python-sc4net/security/code-scanning/2
Use a fixed allowlist mapping from trusted directory contents to absolute paths, and only open paths obtained from that map. This keeps untrusted input as a lookup key only, not as path-construction input at sink time.
Best minimal fix in
tests/mocks.py(insidedo_GET):basename, regex, special names).allowed_filesset + laterjoin/realpathlogic with a dictionary mapping valid filenames indir_pathto their resolved absolute paths.full_file_namefrom this dictionary usingsafe_filepath; if missing, return 404.This preserves current behavior while removing direct tainted-data path construction at the sink.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.