Expose browser pool viewport - #78
Open
IlyaasK wants to merge 2 commits into
Open
Conversation
IlyaasK
requested review from
Sayan- and
tnsardesai
and removed request for
Sayan- and
tnsardesai
July 11, 2026 11:28
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 13, 2026 13:35
027d9e8 to
a2270fa
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
July 13, 2026 13:35
deb65f4 to
df3b49e
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 13, 2026 14:32
a2270fa to
a60a6b4
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
July 13, 2026 14:32
df3b49e to
16097b4
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 13, 2026 15:39
a60a6b4 to
9699f7f
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
July 13, 2026 15:39
16097b4 to
8a4fc9c
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 20, 2026 19:38
9699f7f to
de2d434
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
July 20, 2026 19:38
8a4fc9c to
da6aac2
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 21, 2026 14:46
de2d434 to
cd0ea6e
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
3 times, most recently
from
July 21, 2026 19:51
7c63d7e to
38e7266
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 21, 2026 20:15
0ac42d2 to
1bcac42
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
July 21, 2026 20:15
38e7266 to
1b81db1
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 31, 2026 19:26
1bcac42 to
9396869
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
July 31, 2026 19:28
1b81db1 to
3825585
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
August 3, 2026 14:18
9396869 to
755b731
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
August 3, 2026 14:21
3825585 to
f479654
Compare
Collaborator
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f479654. Configure here.
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
August 3, 2026 14:53
755b731 to
52a37ce
Compare
Read viewport configuration into a typed Terraform object. Reject malformed dimensions and preserve omitted viewport and refresh-rate values without partial state.
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-viewport
branch
from
August 3, 2026 14:53
f479654 to
c851e41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Additive v1 durable read state only. Chrome policy and live acceptance remain separate; no runtime/session fields are exposed.
Tests
Ran focused tests repeatedly, race tests, full short suite, vet, gofmt, module checks, Terraform example fmt, docs drift, and diff checks.
Coverage includes Framework nested-state roundtrip, typed-null omission, omitted refresh rate, malformed/null viewport, missing and non-positive dimensions, invalid refresh rate, and wrong JSON types.
Acceptance not run; live viewport payload behavior remains for the opt-in acceptance slice.
Additional quality verification
@pr78minimum-viewport scenarioNote
Low Risk
Additive read-only computed state on an existing data source with validation and broad unit tests; no write paths or auth changes.
Overview
Adds a computed nested
viewportattribute to thekernel_browser_pooldata source so Terraform can read pool browser window settings from the API.When the API omits viewport, state uses a typed null object (not unknown). When present,
widthandheightmust be positive integers;refresh_rateis optional and must be positive when the field is present. Malformed or invalid API payloads (null viewport, wrong types, missing dimensions, zero/negative values) surface as invalid-response diagnostics instead of silent bad state.Registry docs for the data source are updated to document the nested schema. Unit tests cover schema semantics, read roundtrip, omission, optional refresh rate, minimum values, and rejection cases.
Reviewed by Cursor Bugbot for commit c851e41. Bugbot is set up for automated code reviews on this repo. Configure here.