fix(gh): tolerate non-JSON warnings before gh pr view output - #27
Merged
Conversation
gh can emit warning lines (e.g. auth expiry notices) to stdout before
the JSON payload, causing JSON.parse to fail with 'returned invalid JSON'
even though the JSON itself is valid. The decoder now extracts the JSON
payload by finding the first { or [ and matching closer, so leading or
trailing non-JSON output is stripped before parsing.
Fixes #12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12 —
gh pr view --json ...can emit warning lines (e.g. auth expiry notices) to stdout before the JSON payload, causingJSON.parseto fail with "returned invalid JSON" even though the JSON itself is valid when run directly in a shell.Fix
Add
extractJson()which finds the first{or[and its matching closer (}or]) in the output, stripping any leading/trailing non-JSON text before parsing. Applied to all three GitHub decoders (decodePullList,decodePullView,decodePullWatch).Test
Added a test simulating
ghemitting an auth-warning line before the JSON payload, confirming the decoder successfully extracts and parses the JSON.Verification
bun run typecheckbun run test(127 passing)bun run format:checkbun run lint