feat(stack): add configurable readiness modes - #39
Draft
gabelease wants to merge 2 commits into
Draft
Conversation
hungmuha
approved these changes
Jul 13, 2026
hungmuha
left a comment
There was a problem hiding this comment.
LGTM — well-tested, type-safe readiness modes with sound undo/journal integrity and safe defaults. One release-hygiene nit below.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@kitlangton/stack": patch | |||
There was a problem hiding this comment.
nit: Changeset is marked patch, but this adds a user-facing feature (the stack.readinessMode config key plus --readiness-mode flags on sync and merge). Prior releases bumped analogous additions as minor — e.g. CHANGELOG 0.3.0 stack.blockLink/stack.trunks and 0.4.0 stack skill are all Minor Changes. Consider minor to match convention.
Keep prior behavior under unmanaged while allowing sync and merge to enforce all-ready or root-ready across GitHub and GitLab. Readiness changes run after repair and description updates, and the undo journal preserves prior states so conversions remain reversible.
gabelease
force-pushed
the
feat/readiness-modes
branch
from
July 14, 2026 05:18
c1a6aad to
9bd6e16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds opt-in, provider-neutral readiness policy to stacked PR/MR workflows while preserving current behavior by default.
This PR is scoped only to readiness behavior. The independent Apple Git replay compatibility fix is isolated in #40.
Why
Today every newly created change is ready unless an operator manages draft state separately. On active stacks, that can trigger review and CI repeatedly as lower changes move.
Key changes
Readiness policy
unmanaged,all-ready, androot-readymodes.git config stack.readinessMode.--readiness-modeoverrides tosyncandmerge.unmanagedas the default, including host-default readiness for new changes.Host behavior and safety
syncas the explicit conversion path for existing stacks.undo --applyrestores surviving changes safely.Operational guidance
Risks and review focus
Risk: changing readiness can trigger code-host automation.
→ Promotions occur only after repair is complete; default
unmanagedperforms no readiness transitions.Risk: undo state is shared across linked worktrees.
→ Documentation makes ownership and single-journal behavior explicit, and scoped tests prove independent stacks are not touched.
Review focus: readiness journaling, provider transitions, and post-merge baseline behavior in
Stack.Test plan
All 146 tests pass with Git 2.50.1. On Apple Git 2.39.5, the same seven real-Git tests fail on both upstream
mainand this branch becausecherry-pick --empty=dropis unsupported; #40 isolates that compatibility fix.Rollback
Revert the readiness feature and release commits. Existing installations remain behaviorally unchanged unless a managed readiness mode is configured or passed explicitly.