build: bump Rust toolchain to 1.97.1 - #542
Conversation
The pin had drifted five releases behind upstream stable. Moving to 1.97.1 (released 2026-07-14) picks up compiler and clippy fixes and keeps the MSRV aligned with the toolchain we actually build with. Updates every real pin: the toolchain channel, the workspace MSRV, the Docker builder base image, and the three CI toolchain declarations. flake.nix and preview-config.nix derive their toolchain from rust-toolchain.toml, so they follow automatically; the mdbook workflow stays on `stable` since it only needs cargo to install mdbook-linkcheck2. The `rustc-v1.92.0` in the node-identity test and the `rustc-v1.85.0` in docs/rpc.md are illustrative sentinels, not pins, and are left alone.
🤖 Kimi Code ReviewThis is a straightforward Rust toolchain version bump from 1.92.0 to 1.97.1. The changes are consistent across all configuration files. Feedback: Consistency & Correctness:
Potential Issues:
Security:
Recommendation: Verdict: LGTM pending CI pass. Automated review by Kimi (Moonshot AI) · kimi-k2.5 · custom prompt |
🤖 Claude Code ReviewThis is a straightforward, mechanical toolchain bump — no application logic touched. Review below. Review: PR 542 — bump Rust toolchain to 1.97.1SummaryPure version-pin bump (1.92.0 → 1.97.1) across Correctness
Risk
Nits (non-blocking)
Verdict: Looks good to merge, contingent on CI actually passing on the new toolchain (the description's local verification is convincing but CI is the authoritative check for a pin change like this). Automated review by Claude (Anthropic) · sonnet · custom prompt |
🤖 Codex Code ReviewFindings:
No consensus/fork-choice/attestation/state-transition/XMSS/SSZ correctness concerns showed up here because the PR only changes toolchain metadata, not runtime logic. Verification note: I confirmed the manifests parse cleanly under Rust/Cargo Automated review by OpenAI Codex · gpt-5.4 · custom prompt |
Greptile SummaryUpdates the repository’s Rust toolchain and declared MSRV from 1.92.0 to 1.97.1.
Confidence Score: 5/5The PR appears safe to merge because the Rust version update is consistently applied across the repository’s toolchain consumers. The workspace MSRV, rustup pin, CI jobs, fixture-test action, Docker builder line, and documentation are aligned, with no conflicting active version constraint or changed runtime behavior identified.
|
| Filename | Overview |
|---|---|
| rust-toolchain.toml | Pins rustup-based local and Nix-derived environments to Rust 1.97.1. |
| Cargo.toml | Raises the workspace-inherited minimum supported Rust version to 1.97.1. |
| Dockerfile | Moves the builder image from the Rust 1.92 Bookworm line to the equivalent 1.97 line. |
| .github/workflows/ci.yml | Aligns the primary CI compiler, rustfmt, and clippy toolchain with Rust 1.97.1. |
| .github/actions/run-fixture-tests/action.yml | Aligns fixture-test jobs with the updated workspace toolchain. |
| .github/workflows/daily_loc_report.yml | Aligns the daily reporting workflow with the updated Rust toolchain. |
| CLAUDE.md | Updates the quick-reference documentation to state Rust 1.97.1. |
Reviews (1): Last reviewed commit: "build: bump Rust toolchain to 1.97.1" | Re-trigger Greptile
The node-identity sample response still showed rustc-v1.85.0, two toolchain bumps stale. It is illustrative rather than a pin, but a version string that never tracks reality is worse than no version string, so keep it current with the toolchain.
Motivation
The toolchain pin had drifted five releases behind upstream stable (1.92.0 → 1.97.1, released 2026-07-14). Bumping picks up compiler and clippy fixes and keeps the declared MSRV aligned with the toolchain we actually build with.
Description
Updates every real version pin:
rust-toolchain.tomlchannel1.92.0 → 1.97.1Cargo.tomlrust-version(MSRV) 1.92.0 → 1.97.1Dockerfilerust:1.92-bookworm→rust:1.97-bookworm.github/workflows/ci.ymltoolchain1.92.0 → 1.97.1.github/actions/run-fixture-tests/action.ymltoolchain1.92.0 → 1.97.1.github/workflows/daily_loc_report.ymltoolchain1.92.0 → 1.97.1CLAUDE.mddocs/rpc.mdrustc-v1.85.0→rustc-v1.97.1The
docs/rpc.mdstring is illustrative rather than a pin, but it was two bumps stale, so it is refreshed here to keep it tracking reality.Deliberately not changed:
flake.nixandpreview-config.nixderive the toolchain fromrust-toolchain.toml, so they follow automatically..github/workflows/pr-main_mdbook.ymlstays ontoolchain: stable, since it only needs cargo to installmdbook-linkcheck2and was never pinned.crates/net/rpc/src/node.rs(rustc-v1.92.0) is an injected test sentinel (v9.9.9-test-deadbeef) asserted to round-trip verbatim. It does not read the real rustc version and the test passes regardless, so it is left alone.Verification
Run locally on
rustc 1.97.1 (8bab26f4f 2026-07-14):cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo test --workspace --releaseCargo.lockchurnrust:1.97-bookwormon Docker HubThe 7 ignored tests are the pre-existing
#[ignore]leanVM crypto tests.