fix(openai): suppress Pydantic serializer warning on structured output parsed field#37727
Merged
ccurme (ccurme) merged 6 commits intoJul 8, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Thanks for this! Released in langchain-openai 1.3.4. |
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37723
The OpenAI SDK types the parsed field on ChatCompletionMessage restrictivel, when with_structured_output() populates it with an actual Pydantic model, model_dump() emits a PydanticSerializationUnexpectedValue warning even though the field is being excluded.
Adding warnings=False to the model_dump() call in _create_chat_result suppresses this. The field is already intentionally excluded and handled separately downstream, so no information is lost.
Also updates test_create_chat_result_avoids_parsed_model_dump_warning to use a mock type closer to the real SDK, ensuring the test actually catches this regression.