Skip to content

Added NS_UNAVAILABLE flag to all unneeded super initializers (NSObject init) - #477

Merged
joshaber merged 1 commit into
libgit2:masterfrom
javiertoledo:the-fix-i-think-that-makes-sense-for-xcode7-complains
Jul 6, 2015
Merged

Added NS_UNAVAILABLE flag to all unneeded super initializers (NSObject init)#477
joshaber merged 1 commit into
libgit2:masterfrom
javiertoledo:the-fix-i-think-that-makes-sense-for-xcode7-complains

Conversation

@javiertoledo

Copy link
Copy Markdown
Contributor

I think that this fix is better than the previously submitted in #476, as XCode marks init usages as “unavailable” and, if for some reason an init call is achieved in runtime, it raises a runtime error via NSAssert.

@mdiep

mdiep commented Jul 5, 2015

Copy link
Copy Markdown
Contributor

This looks like the right fix to me.

@phatblat

phatblat commented Jul 5, 2015

Copy link
Copy Markdown
Member

👍

@joshaber joshaber self-assigned this Jul 6, 2015
@joshaber

joshaber commented Jul 6, 2015

Copy link
Copy Markdown
Member

This is great, thanks so much!

joshaber added a commit that referenced this pull request Jul 6, 2015
…sense-for-xcode7-complains

Added NS_UNAVAILABLE flag to all unneeded super initializers (NSObject init)
@joshaber
joshaber merged commit 083a733 into libgit2:master Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants