Skip to content

[NPU]: Add NPU support for the mrope operator - #992

Merged
Tcc0403 merged 1 commit into
linkedin:mainfrom
TianHao324:mrope
Jan 2, 2026
Merged

[NPU]: Add NPU support for the mrope operator#992
Tcc0403 merged 1 commit into
linkedin:mainfrom
TianHao324:mrope

Conversation

@TianHao324

@TianHao324 TianHao324 commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

Summary

Mainly to complete the adaptation of the _triton_qwen2vl_mrope operator on the NPU:
1、Solving the operator ub overflow problem
2、Resolves issues with some concat operations not supported by ascend.
3、Fixed legacy issues with the rope operator

Testing Done

image

Verified on Ascend NPU 910B4:
MROPE forward and backward pass tests

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@TianHao324
TianHao324 force-pushed the mrope branch 12 times, most recently from f92a96d to c1af5cc Compare December 31, 2025 02:58
@TianHao324

Copy link
Copy Markdown
Contributor Author

Hi @Tcc0403 @zheliuyu @noemotiovon
When you have a moment, could you help take a look at this code? Thanks!

@TianHao324

Copy link
Copy Markdown
Contributor Author

@Tcc0403 It seems I don't have permission to add repository secrets,which is causing the check to fail.

╭─ Error ──────────────────────────────────────────────────────────────────────╮
│ Token missing. Could not authenticate client. If you have token credentials, │
│ see modal.com/docs/reference/modal.config for setup help. If you are a new   │
│ user, register an account at modal.com, then run `modal token new`.          │
╰──────────────────────────────────────────────────────────────────────────────╯

@Tcc0403

Tcc0403 commented Dec 31, 2025

Copy link
Copy Markdown
Collaborator

@Tcc0403 It seems I don't have permission to add repository secrets,which is causing the check to fail.

Yeah, it's fine. Just ignore it. We didn't enable nvidia-ci for fork branches.

Comment thread src/liger_kernel/ops/backends/_ascend/ops/qwen2vl_mrope.py
Comment thread src/liger_kernel/ops/backends/_ascend/ops/rope.py
@Tcc0403
Tcc0403 merged commit aac07f3 into linkedin:main Jan 2, 2026
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants