Skip to content

TPT-4593: Miscellaneous updates - #18

Open
zliang-akamai wants to merge 5 commits into
v1from
zhiwei/misc-updates
Open

TPT-4593: Miscellaneous updates#18
zliang-akamai wants to merge 5 commits into
v1from
zhiwei/misc-updates

Conversation

@zliang-akamai

@zliang-akamai zliang-akamai commented Jul 31, 2026

Copy link
Copy Markdown
Member

📝 Description

Misc maintenance updates for this composite action:

  • Harden action.yml by binding untrusted inputs through step env instead of interpolating them into run: scripts
  • Bump GitHub Actions used in workflows and action.yml (checkout, setup-python, dependency-review-action, github-script, labeler pin)
  • Add Dependabot config for monthly github-actions updates
  • Add AGENTS.md contributor/agent guidance and a .gitignore for .DS_Store

@zliang-akamai zliang-akamai changed the title Misc updates Miscellaneous updates Jul 31, 2026
@zliang-akamai
zliang-akamai marked this pull request as ready for review July 31, 2026 20:46
@zliang-akamai
zliang-akamai requested review from a team as code owners July 31, 2026 20:46
@zliang-akamai
zliang-akamai requested review from jbilskiAkam and psnoch-akamai and removed request for a team July 31, 2026 20:46
@zliang-akamai zliang-akamai changed the title Miscellaneous updates TPT-4592: Miscellaneous updates Jul 31, 2026
@zliang-akamai zliang-akamai changed the title TPT-4592: Miscellaneous updates TPT-4593: Miscellaneous updates Jul 31, 2026
@zliang-akamai
zliang-akamai requested a review from Copilot July 31, 2026 20:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs maintenance updates for the composite GitHub Action by hardening how untrusted inputs are handled in action.yml, modernizing the referenced GitHub Actions in workflows, and adding repository automation/docs hygiene files.

Changes:

  • Bind inputs.token via step env in action.yml and reuse it in run: commands.
  • Bump GitHub Actions versions/pins across the action and workflows.
  • Add Dependabot configuration plus contributor/agent guidance and a .DS_Store ignore.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
AGENTS.md Adds agent/contributor guidance for repo shape, editing rules, validation, and PR conventions.
action.yml Hardens token handling and adjusts install command to use environment variables.
.gitignore Ignores .DS_Store.
.github/workflows/test.yml Updates actions/checkout version used in integration test workflow.
.github/workflows/labeler.yml Updates actions/checkout and labeler action pin.
.github/workflows/dependency-review.yml Updates actions/checkout and dependency review action versions.
.github/workflows/clean-release-notes.yml Updates actions/github-script version.
.github/dependabot.yml Adds monthly Dependabot updates for github-actions.
Suppressed comments (1)

action.yml:79

  • Writing LINODE_CLI_TOKEN to $GITHUB_ENV with echo "VAR=$TOKEN" allows newline injection: a token containing newlines could append additional environment variables or malformed entries. Use the documented heredoc form for environment files so the value is treated as a single entry even if it contains newlines.
      if: ${{ inputs.token != '' }}
      shell: bash
      env:
        TOKEN: ${{ inputs.token }}
      run: echo "LINODE_CLI_TOKEN=$TOKEN" >> "$GITHUB_ENV"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread action.yml
Comment on lines 25 to +29
- name: Mask the input token
shell: bash
run: echo "::add-mask::${{ inputs.token }}"
env:
TOKEN: ${{ inputs.token }}
run: echo "::add-mask::$TOKEN"
Comment thread action.yml
Comment on lines 70 to 72
- name: Install the Linode CLI
run: pip3 install ${{ env.pip_args }}linode-cli${{ env.version_extension }}
run: pip3 install ${pip_args}linode-cli${version_extension}
shell: bash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants