TPT-4593: Miscellaneous updates - #18
Open
zliang-akamai wants to merge 5 commits into
Open
Conversation
Pass token and install args through env vars instead of expanding
${{ }} expressions directly in composite run steps.
zliang-akamai
marked this pull request as ready for review
July 31, 2026 20:46
zliang-akamai
requested review from
jbilskiAkam and
psnoch-akamai
and removed request for
a team
July 31, 2026 20:46
There was a problem hiding this comment.
Pull request overview
This PR performs maintenance updates for the composite GitHub Action by hardening how untrusted inputs are handled in action.yml, modernizing the referenced GitHub Actions in workflows, and adding repository automation/docs hygiene files.
Changes:
- Bind
inputs.tokenvia stepenvinaction.ymland reuse it inrun:commands. - Bump GitHub Actions versions/pins across the action and workflows.
- Add Dependabot configuration plus contributor/agent guidance and a
.DS_Storeignore.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
AGENTS.md |
Adds agent/contributor guidance for repo shape, editing rules, validation, and PR conventions. |
action.yml |
Hardens token handling and adjusts install command to use environment variables. |
.gitignore |
Ignores .DS_Store. |
.github/workflows/test.yml |
Updates actions/checkout version used in integration test workflow. |
.github/workflows/labeler.yml |
Updates actions/checkout and labeler action pin. |
.github/workflows/dependency-review.yml |
Updates actions/checkout and dependency review action versions. |
.github/workflows/clean-release-notes.yml |
Updates actions/github-script version. |
.github/dependabot.yml |
Adds monthly Dependabot updates for github-actions. |
Suppressed comments (1)
action.yml:79
- Writing
LINODE_CLI_TOKENto$GITHUB_ENVwithecho "VAR=$TOKEN"allows newline injection: a token containing newlines could append additional environment variables or malformed entries. Use the documented heredoc form for environment files so the value is treated as a single entry even if it contains newlines.
if: ${{ inputs.token != '' }}
shell: bash
env:
TOKEN: ${{ inputs.token }}
run: echo "LINODE_CLI_TOKEN=$TOKEN" >> "$GITHUB_ENV"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
25
to
+29
| - name: Mask the input token | ||
| shell: bash | ||
| run: echo "::add-mask::${{ inputs.token }}" | ||
| env: | ||
| TOKEN: ${{ inputs.token }} | ||
| run: echo "::add-mask::$TOKEN" |
Comment on lines
70
to
72
| - name: Install the Linode CLI | ||
| run: pip3 install ${{ env.pip_args }}linode-cli${{ env.version_extension }} | ||
| run: pip3 install ${pip_args}linode-cli${version_extension} | ||
| shell: bash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Misc maintenance updates for this composite action:
action.ymlby binding untrusted inputs through stepenvinstead of interpolating them intorun:scriptsaction.yml(checkout,setup-python,dependency-review-action,github-script, labeler pin)github-actionsupdatesAGENTS.mdcontributor/agent guidance and a.gitignorefor.DS_Store