fix: skip merged-away members in llm merges - #4403
Merged
Merged
Conversation
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents stale member merge suggestions from failing LLM merge workflows.
Changes:
- Skips suggestions referencing secondaries merged in the current batch.
- Checks member existence before inserting no-merge records.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
services/libs/data-access-layer/src/member_merge/index.ts |
Guards no-merge inserts against missing members. |
services/apps/merge_suggestions_worker/src/workflows/mergeMembersWithLLM.ts |
Tracks merged-away members within a workflow run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joanagmaia
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mergeMembersWithLLMwas failing roughly every 2 hours when a batch contained overlapping member IDs: after merging pair A–B, asyncfinishMemberMerginghard-deleted B, then a later pair like C–B hitmemberNoMergeFK (memberNoMerge_noMergeId_fkey) and killed the run.Changes
insertMemberNoMergewithEXISTSchecks so no-merge rows are only inserted when both member IDs still exist