Skip to content

fix: skip merged-away members in llm merges - #4403

Merged
skwowet merged 1 commit into
mainfrom
fix/merge-members-llm-nomerge-deleted-member
Jul 27, 2026
Merged

fix: skip merged-away members in llm merges#4403
skwowet merged 1 commit into
mainfrom
fix/merge-members-llm-nomerge-deleted-member

Conversation

@skwowet

@skwowet skwowet commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

mergeMembersWithLLM was failing roughly every 2 hours when a batch contained overlapping member IDs: after merging pair A–B, async finishMemberMerging hard-deleted B, then a later pair like C–B hit memberNoMerge FK (memberNoMerge_noMergeId_fkey) and killed the run.

Changes

  • Track secondaries merged in the current run and skip (then remove) later suggestions that still reference them before fetching member data for the LLM
  • Guard insertMemberNoMerge with EXISTS checks so no-merge rows are only inserted when both member IDs still exist

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 27, 2026 14:00
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@skwowet skwowet changed the title fix: skip merged-away members in LLM merge suggestions fix: skip merged-away members in llm merges Jul 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prevents stale member merge suggestions from failing LLM merge workflows.

Changes:

  • Skips suggestions referencing secondaries merged in the current batch.
  • Checks member existence before inserting no-merge records.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
services/libs/data-access-layer/src/member_merge/index.ts Guards no-merge inserts against missing members.
services/apps/merge_suggestions_worker/src/workflows/mergeMembersWithLLM.ts Tracks merged-away members within a workflow run.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread services/libs/data-access-layer/src/member_merge/index.ts
@skwowet
skwowet merged commit 1b73b0e into main Jul 27, 2026
18 checks passed
@skwowet
skwowet deleted the fix/merge-members-llm-nomerge-deleted-member branch July 27, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants