Skip to content

refactor(lnori): use a pageCache rather than fetching the same page#2317

Draft
K1ngfish3r wants to merge 5 commits into
lnreader:masterfrom
K1ngfish3r:lnorihuh
Draft

refactor(lnori): use a pageCache rather than fetching the same page#2317
K1ngfish3r wants to merge 5 commits into
lnreader:masterfrom
K1ngfish3r:lnorihuh

Conversation

@K1ngfish3r

Copy link
Copy Markdown
Collaborator

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)

No relevant issues

  • use a pool to send 5 requests instead of 30 at the same time
  • cache the page so the page doesnt have to be downloaded over and over during chapter downloads

@K1ngfish3r
K1ngfish3r marked this pull request as draft July 17, 2026 19:27
@MonomoySama

MonomoySama commented Jul 20, 2026

Copy link
Copy Markdown

For Lnori, i think the original is good enough, although it takes 2min+ for big entries, like Rezero, Mushoku tensei etc. at least they open fully and will later stay opened in cache. The problem is just that one volume will always be missing for some reason and some novels like classroom elite and reincarnated as slime are "can't parse page". So rather than increasing loading speed, i think fixing that missing volume problem is good enough, as for parse page, i think it's related to that missing volume problem. And it's not like the site updates new volumes every day that we gotta update entries everyday.

@MonomoySama

MonomoySama commented Jul 20, 2026

Copy link
Copy Markdown

Idk why and how, but it's working fully fine now.... Wtf? Cant parse page novels, fixed. Missing volume, fixed..... Just that the loading speed is same. So no one fixed anything and it got fixed itself? Hmm... Hope it's not temporary. Well then, you can focus on making a novel phoenxi plugin, so i can migrate there from novelfire

@MonomoySama

MonomoySama commented Jul 21, 2026

Copy link
Copy Markdown

nevermind, was indeed a temporary fix. now giving same problems again. see this #2334 maybe the problem is how it's sending the fetch requests

@K1ngfish3r

Copy link
Copy Markdown
Collaborator Author

I am assuming the number of requests become too many due to this plugin not caching anything

@MonomoySama

Copy link
Copy Markdown

I am assuming the number of requests become too many due to this plugin not caching anything

Well, last time you almost fixed it, loading time became instant, all volumes were there too, but only for few novels, rest were all inf loading, remember?

@K1ngfish3r

Copy link
Copy Markdown
Collaborator Author

ie: other people using the current plugin, unrelated to this PR

multiple times

Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
@K1ngfish3r
K1ngfish3r force-pushed the lnorihuh branch 2 times, most recently from 90f420b to 972f193 Compare July 23, 2026 19:01
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
@K1ngfish3r
K1ngfish3r force-pushed the lnorihuh branch 2 times, most recently from 4405182 to b9b19bd Compare July 23, 2026 20:45
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants