Beacons have wrong settings - #132
Closed
gregbreen wants to merge 2 commits into
Closed
Conversation
|
Thanks a lot, @gregbreen, for this contribution. This glitch will be rectified asap. I am very sorry to tell you that I will not be able to merge your PR because the contributing guidelines for this project have not been setup yet. Also, your PR is missing little details: But be assured that this will be fixed in the next release. Thanks again! |
Author
|
No worries @beitler . I'm not sure I understand why the contributing guidelines is a blocker, but that's OK. I'm happy to revise the PR to get it to an acceptable level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves the problem of devices not receiving beacons (as discussed in #129 ). Per the regional parameters specs for 1.0.3 and 1.1 beacon radio frames should:
These are four differences compared to all other frame types. The current release has the header present, has the polarity inverted, and sends the standard 8 symbol preamble.
From the 1.0.3 spec:
And from the 1.0.3 regional parameters:
That is for AU915, but the beacon signal polarity is non-inverted in every region.