Add Mojave-style tabs, which also supports Dark Mode

[ychin]

Add a new tab style "Mojave". The files were copied from Yosemite-style tabs but with additional improvements. It now reads the colors from an asset catalog with colors for both dark and light modes. The colors and style are also retuned to look more like native Mojave tabs. The new tab and close tab buttons are now using a style much more similar to what native macOS are like, with the close tab button showing up when mouse is hovering over a particular tab.

Reason for cloning PSMYosemiteTabStyle is to avoid having too many special cases in a single file and to avoid breaking its behaviors on older systems. Also, PSMTabBarControl is mostly a dead project, so it's wise to modify existing code as little as possible.

MacVim will only use this style if it's compiled with Mojave SDKs and it's actually being run in Mojave (10.14) or higher.

Fix #775

[grr]

after upgrading to 8.1.560 on Sierra 10.12.6, which does not have dark mode, my titlebar is now completely black. can't read the title text and it's also not as easy to grab the titlebar to move the window since my colorscheme background color is also black:

[ychin]

Do you have any local settings? Can you try setting colorscheme to something else, let's say a light one like "morning" and see if that changes the titlebar color? I can look into fixing it later today.

…

On Wed, Dec 5, 2018 at 12:53 PM grr ***@***.***> wrote: after upgrading to 8.1.560 on Sierra 10.12.6, which does not have dark mode, my titlebar is now completely black. can't read the title text and it's also not as easy to grab the titlebar to move the window since my colorscheme background color is also black: [image: screen shot 2018-12-05 at 14 51 01] <https://user-images.githubusercontent.com/690894/49543237-45d5e600-f89d-11e8-9e9a-5f31346cebea.png> — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#791 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKTqUACbRZDQhZUgDpo_nbsZtmxeWYXks5u2DIpgaJpZM4YywU0> .

[grr]

yes, running with -i NONE -u NONE shows a normal (non-dark) titlebar. i wouldn't have expected anything in my vimrc to affect part of the window manager. i'll try to figure out which setting is the root cause.

[grr]

ok, running again with -i NONE -u NONE, then :set nocompatible, then choose any colorscheme, and the titlebar becomes the background color, so it's not just binary setting of normal/dark titlebar. using the "blue" colorscheme will result in a blue titlebar:

[ychin]

Thanks for the info. I think I know where the problem is but I would need to find a way to test this first.

Filed #799 to help track this since this is a separate issue from dark mode tabs. Please leave further comments there.

[mfn]

Just received the auto update on Mac, with dark mode support. Wow!

Thanks, it's the small details ;-) 🙇‍♂️

[kkkrist]

Yes, it's great! Just wondering: Is there a way to manually turn it on? I'd prefer to just use MacVim with dark mode and keep the rest of the system "light".

[peterrenshaw]

Titlebar requires contrasting text colour. Usable but PIA. (OS X El Capitan 10.11.X)

[ychin]

Just wondering: Is there a way to manually turn it on? I'd prefer to just use MacVim with dark mode and keep the rest of the system "light".

@kkkrist Sorry but I would have to say probably not for now. MacVim currently supports a fair amount of options, and preferences like this is actually the source of a fair amount of bugs since it makes it harder to code and test. The colors are also toggled directly by dark mode so it would involve some work to refactor. If you use "light mode" for the OS the window frame will appear light anyway so it won't be completely dark.

Feel free to file an issue for tracking though.

[kkkrist]

@kkkrist Sorry but I would have to say probably not for now. MacVim currently supports a fair amount of options, and preferences like this is actually the source of a fair amount of bugs since it makes it harder to code and test. The colors are also toggled directly by dark mode so it would involve some work to refactor. If you use "light mode" for the OS the window frame will appear light anyway so it won't be completely dark.

Feel free to file an issue for tracking though.

Thanks for your answer! I had just hoped there is some setting or call being triggered when you set your desktop to dark mode that's also accessible to users.

It's just that I prefer dark themes and I've become a bit spoilt by iTerm which can be set to display a dark window frame and dark tabs independently from the macOS desktop settings.

But it's really not that important or even worth an issue.

I have a lot of respect for what you do, the work on MacVim is very much appreciated!

[genivia-inc]

I'm having the exact same issue as @grr with version 8.1.560 on Mac OS 10.12.6: my title bar has the background color (dark blue color DarkBlue in .vimrc) with black title text, which makes it impossible to read. Any suggestions on how to change my .vimrc are appreciated!

[ychin]

@genivia-inc Use a different colorscheme for now. There is a PR on this and there will be a release to fix this soon (https://github.com/macvim-dev/macvim/milestone/1).

Also please use #799 for tracking this. This bug is not due to dark tabs.