Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

fix bug where logo did not appear if layer added after map init#1324

Merged
riastrad merged 8 commits into
publisher-productionfrom
riastrad/logo-fix
Mar 19, 2020
Merged

fix bug where logo did not appear if layer added after map init#1324
riastrad merged 8 commits into
publisher-productionfrom
riastrad/logo-fix

Conversation

@riastrad

Copy link
Copy Markdown

Fixes #1314, where the mapbox logo would not be added to maps when they added the mapbox tilelayer's after initialization of L.mapbox.map.

However, note that it does not correct the behavior noted in #1227, as there are still problems with the logo appearing when a styleLayer is added to the map after the map object's initialization.

cc/ @mapbox/static-apis

@riastrad riastrad added the bug label Mar 18, 2020
@riastrad riastrad added this to the v3.3.0 milestone Mar 18, 2020
@riastrad
riastrad requested a review from a team March 18, 2020 22:04
@riastrad riastrad self-assigned this Mar 18, 2020

@jaericson jaericson left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

Comment thread src/map.js Outdated
Comment thread src/mapbox_logo.js Outdated
@riastrad
riastrad requested a review from jaericson March 19, 2020 18:02

@jaericson jaericson left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more comment/question

Comment thread test/spec/mapbox_logo.js
@riastrad
riastrad requested a review from jaericson March 19, 2020 20:10

@jaericson jaericson left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks Josh!

@riastrad
riastrad merged commit dae3498 into publisher-production Mar 19, 2020
@riastrad
riastrad deleted the riastrad/logo-fix branch March 19, 2020 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix for missing wordmark attribution on older mapbox.js maps

2 participants