Allow the homeserver to finish partial-state joining before teardown#570
Merged
Conversation
Since the partial state join tests reuse the same homeserver deployment, it is important that each test leaves the homeserver in an acceptable state for subsequent tests. In particular, we must allow in-progress partial-state joins to complete before tearing down Complement servers, otherwise the homeserver may mark Complement hostname:port combinations as offline and refuse to contact them in subsequent tests.
DMRobertson
approved these changes
Dec 13, 2022
DMRobertson
left a comment
DMRobertson
left a comment
Contributor
There was a problem hiding this comment.
I think this means we now automatically call awaitPartialStateJoinCompletion via defer. We were already doing so in some places. Is there any danger in doing so again? (I think not: we just recheck that Synapse has fully joined by calling /members?)
Contributor
Author
It should be fine. There are no side effects apart from taking extra time. |
2 tasks
MadLittleMods
added a commit
that referenced
this pull request
Jul 21, 2026
Follow-up to #894 which removes another part of the clean-up code in this file and #880 which introduces a better way to avoid the test pollution and obsoletes the need for all of this cleanup logic. See the PR description there for a more complete context on why. `Destroy(...)` was originally introduced in this context: > Since the partial state join tests reuse the same homeserver deployment, it is important that each test leaves the homeserver in an acceptable state for subsequent tests. In particular, we must allow in-progress partial-state joins to complete before tearing down Complement servers, otherwise the homeserver may mark Complement `hostname:port` combinations as offline and refuse to contact them in subsequent tests. > > *-- #570 But thanks to #880 we no longer use the same `hostname:port` for engineered homeservers anymore. --- Given the nature of these changes, this also fixes the goroutine panic that can happen when the waiter finishes after the test and `t` is used after the test finishes, see #894 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the partial state join tests reuse the same homeserver deployment,
it is important that each test leaves the homeserver in an acceptable
state for subsequent tests. In particular, we must allow in-progress
partial-state joins to complete before tearing down Complement servers,
otherwise the homeserver may mark Complement hostname:port combinations
as offline and refuse to contact them in subsequent tests.
These issues have 502 Bad Gateway failures:
Closes matrix-org/synapse#13564.
Closes matrix-org/synapse#14245.
Closes matrix-org/synapse#14543.