Restrict font-weight-absolute values to numbers in the 1...1000 range - #420
Merged
Merged
Conversation
papandreou
added a commit
to papandreou/css-generators
that referenced
this pull request
Jul 21, 2020
Contributor
|
@papandreou this makes sense to me, but I'd rather wait until the change is accepted into the spec before we make the change here. Ping me when it gets accepted. |
Contributor
Author
|
@chrisdavidmills, ping! The spec PR got merged now 🤗 |
Contributor
|
that was quick ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My fuzz testing tool generates crazy numerical
font-weightvalues because the range isn't restricted by the grammar.I suggest limiting it to 1...1000 as per the extra notes in the CSS Fonts Module Level 4 Working Draft. I'm proposing the equivalent change to the spec here: w3c/csswg-drafts#5345