feat: Identity Redux + Custom Radio Channels - #532
Draft
Koollan wants to merge 6 commits into
Draft
Conversation
Reworks how ID works and adds custom radio channels to factions
github-actions
Bot
added
S: Untriaged
size/L
S: Needs Review
Changes: UI
S: Merge Conflict
labels
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Collaborator
Author
|
Ope. Some merge conflicts because of the faction tag system (wasn't merged when I started this branch) |
For re-merging
Contributor
|
RSI Diff Bot; head commit 11f714e merging into 01fcf45 Resources/Textures/Clothing/Uniforms/Jumpskirt/paramedic.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/paramedic.rsi
Resources/Textures/Clothing/Hands/Gloves/forensicnitrile.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/coroner.rsi
Resources/Textures/Effects/eye_tether.rsi
|
This reverts commit 11f714e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEATURES:
Huge refactor of ID cards, Identity in general and Radio channels!
ID cards now have ID numbers that are associated directly with their faction and monetary accounts. When a new ID is printed, the old ID gets fully deleted (new fancy self ashing plastic idk).
Job Icons can now be set with the faction management console for roles assignments. These job icons show on IDs and in administrative overlay HUDs.
Framework implemented for being able to have 'custom names' assigned to IDs that can still be looked up in crew records (will be useful for the incoming Synthetics rework).
Custom radio channels that can be configured in the faction management console with custom colors and custom hotkeys.
Radio headsets have functional multi-faction listening and transmitting toggleable. (The "All" option still does not work as intended, this is a pre-existing bug)
!! DISCLAIMER !!
AI (VSCode GitHub CoPilot) was used for the express purpose of the following:
Diagnosing build errors
Targeting Systems, Components, .cs files in general and .yml for changes
Troubleshooting XAML/UX errors
Locating UI components to re-use
A thorough review is requested for this PR. Testing shows promising results but I may not have tested every use case.