Devices: Replace Metadata with MM::CameraImageMetadata - #843
Merged
Conversation
marktsuchida
force-pushed
the
metadata-map
branch
3 times, most recently
from
February 19, 2026 04:48
b89a7f3 to
99013af
Compare
This is a clean replacement for the uses of Metadata (ImageMetadata.h) in device (camera) adapters. Unit tests show how existing usage of Metadata can be migrated to MM::MetadataMap. The member function to add/put/set a tag is named AddTag() so that it is never mistaken for a member function of the Metadata class used in camera code up to now. (It has nothing to do with `MM::Camera::AddTag()`, but there should be no confusion there.) (Partially assisted by Claude Code; any errors are mine.)
For the camera device side of the tests. (Assisted by Claude Code; any errors are mine.)
A bit indirect, but test from Core for convenience. (Assisted by Claude Code; any errors are mine.)
Switch to MM::CameraImageMetadata.
marktsuchida
force-pushed
the
metadata-map
branch
from
February 19, 2026 13:35
99013af to
b68dfa0
Compare
marktsuchida
force-pushed
the
metadata-map
branch
from
February 19, 2026 13:45
858a866 to
e31eaed
Compare
2 tasks
marktsuchida
changed the title
marktsuchida
marked this pull request as ready for review
February 19, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to be the first half of #797.
Added
CameraImageMetadata(CameraImageMetadata.h) as an equivalent replacement toMetadata(ImageMetadata.h), for all uses by cameras. MMDevice unit tests added.To do in this PR:
CCameraBaseMetadatauses by camerasA separate PR will finish #797 by moving
ImageMetadata.hto MMCore, after out-of-tree camera adapters have a chance to update.