Skip to content

[UWP] Use selectAction's title as the accessible name for a link - #4046

Merged
paulcam206 merged 3 commits into
masterfrom
paulcam/uwp-selectaction-accessibility
May 21, 2020
Merged

[UWP] Use selectAction's title as the accessible name for a link#4046
paulcam206 merged 3 commits into
masterfrom
paulcam/uwp-selectaction-accessibility

Conversation

@paulcam206

@paulcam206 paulcam206 commented May 20, 2020 •
edited by ghost
Loading

Copy link
Copy Markdown
Member

Related Issue

Fixes #3950

Description

When a TextRun has a selectAction with a valid title, use that title as the accessible name for the link (see #3950 for sample card text).

How Verified

  • Manual inspection in debugger
  • AccessibilityInsights

image
image

Microsoft Reviewers: Open in CodeFlow

@paulcam206 paulcam206 added Platform-XAML Bugs or features related to Xaml Renderer Area-Accessibility Bugs around feature accessibility AdaptiveCards v1.2.9 labels May 20, 2020
@paulcam206

paulcam206 commented May 20, 2020

Copy link
Copy Markdown
Member Author

@nimercer - FYI :)

@paulcam206
paulcam206 requested a review from RebeccaAnne May 20, 2020 22:30
@paulcam206

paulcam206 commented May 20, 2020

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

azure-pipelines Bot commented May 20, 2020

Copy link
Copy Markdown
No pipelines are associated with this pull request.

jwoo-msft
jwoo-msft approved these changes May 21, 2020
View reviewed changes

@jwoo-msft jwoo-msft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@paulcam206

paulcam206 commented May 21, 2020

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

azure-pipelines Bot commented May 21, 2020

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@paulcam206
paulcam206 merged commit e7f8c6b into master May 21, 2020
@paulcam206
paulcam206 deleted the paulcam/uwp-selectaction-accessibility branch May 21, 2020 17:09
paulcam206 added a commit that referenced this pull request May 28, 2020
@paulcam206
[UWP] Port RichTextBlock selectAction accessibility name fix
153ea3d 
Fixes #3950 in `release/1.2`
Original PR: #4046
Original commit: e7f8c6b
@paulcam206 paulcam206 mentioned this pull request May 28, 2020
Merged
paulcam206 added a commit that referenced this pull request May 29, 2020
@paulcam206
[UWP] Port RichTextBlock selectAction accessibility name fix (#4067)
4474fe1 
Fixes #3950 in `release/1.2`
Original PR: #4046
Original commit: e7f8c6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwoo-msft jwoo-msft jwoo-msft approved these changes
@shalinijoshi19 shalinijoshi19 Awaiting requested review from shalinijoshi19
@almedina-ms almedina-ms Awaiting requested review from almedina-ms
@RebeccaAnne RebeccaAnne Awaiting requested review from RebeccaAnne

Assignees

No one assigned

Labels

Area-Accessibility Bugs around feature accessibility Platform-XAML Bugs or features related to Xaml Renderer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UWP][Accessibility] RichTextBlock TextRun with Action should use action title as Screen Reader text

2 participants

@paulcam206 @jwoo-msft